From: Mazdak Farrokhzad <twingoow@gmail.com>
Date: Mon, 30 Dec 2019 06:27:56 +0000 (+0100)
Subject: Show scrutinee expr type for struct fields.
X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=960acb044bcefc46520cee263b6877160fd296ca;p=rust.git

Show scrutinee expr type for struct fields.

TODO: The type is wrong and will be fixed in later commits.
---

diff --git a/src/librustc_typeck/check/pat.rs b/src/librustc_typeck/check/pat.rs
index 397f8682ede..1f374c3fe20 100644
--- a/src/librustc_typeck/check/pat.rs
+++ b/src/librustc_typeck/check/pat.rs
@@ -577,8 +577,16 @@ fn check_pat_struct(
         self.demand_eqtype_pat(pat.span, expected, pat_ty, discrim_span);
 
         // Type-check subpatterns.
-        if self.check_struct_pat_fields(pat_ty, pat.hir_id, pat.span, variant, fields, etc, def_bm)
-        {
+        if self.check_struct_pat_fields(
+            pat_ty,
+            pat.hir_id,
+            pat.span,
+            variant,
+            fields,
+            etc,
+            def_bm,
+            discrim_span,
+        ) {
             pat_ty
         } else {
             self.tcx.types.err
@@ -859,6 +867,7 @@ fn check_struct_pat_fields(
         fields: &'tcx [hir::FieldPat<'tcx>],
         etc: bool,
         def_bm: BindingMode,
+        discrim_span: Option<Span>,
     ) -> bool {
         let tcx = self.tcx;
 
@@ -908,7 +917,7 @@ fn check_struct_pat_fields(
                 }
             };
 
-            self.check_pat(&field.pat, field_ty, def_bm, None);
+            self.check_pat(&field.pat, field_ty, def_bm, discrim_span);
         }
 
         let mut unmentioned_fields = variant
diff --git a/src/test/ui/pattern/pat-struct-field-expr-has-type.rs b/src/test/ui/pattern/pat-struct-field-expr-has-type.rs
new file mode 100644
index 00000000000..1d18214de7f
--- /dev/null
+++ b/src/test/ui/pattern/pat-struct-field-expr-has-type.rs
@@ -0,0 +1,9 @@
+struct S {
+    f: u8,
+}
+
+fn main() {
+    match (S { f: 42 }) {
+        S { f: Ok(_) } => {} //~ ERROR mismatched types
+    }
+}
diff --git a/src/test/ui/pattern/pat-struct-field-expr-has-type.stderr b/src/test/ui/pattern/pat-struct-field-expr-has-type.stderr
new file mode 100644
index 00000000000..7962c376a92
--- /dev/null
+++ b/src/test/ui/pattern/pat-struct-field-expr-has-type.stderr
@@ -0,0 +1,14 @@
+error[E0308]: mismatched types
+  --> $DIR/pat-struct-field-expr-has-type.rs:7:16
+   |
+LL |     match (S { f: 42 }) {
+   |           ------------- this expression has type `u8`
+LL |         S { f: Ok(_) } => {}
+   |                ^^^^^ expected `u8`, found enum `std::result::Result`
+   |
+   = note: expected type `u8`
+              found enum `std::result::Result<_, _>`
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0308`.