From: bors Date: Sun, 14 Sep 2014 00:51:05 +0000 (+0000) Subject: auto merge of #17189 : bkoropoff/rust/extern-existing-crate, r=alexcrichton X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=931b11549f3aab00aaaaff39cce33c0f7219b3b6;p=rust.git auto merge of #17189 : bkoropoff/rust/extern-existing-crate, r=alexcrichton When checking for an existing crate, compare against the `crate_metadata::name` field, which is the crate name which was requested during resolution, rather than the result of the `crate_metadata::name()` method, which is the crate name within the crate metadata, as these may not match when using the --extern option to `rustc`. This fixes spurious "multiple crate version" warnings under the following scenario: - The crate `foo`, is referenced multiple times - `--extern foo=./path/to/libbar.rlib` is specified to rustc - The internal crate name of `libbar.rlib` is not `foo` The behavior surrounding `Context::should_match_name` and the comments in `loader.rs` both lead me to believe that this scenario is intended to work. Fixes #17186 --- 931b11549f3aab00aaaaff39cce33c0f7219b3b6