From: Oliver Middleton <olliemail27@gmail.com>
Date: Thu, 2 Jun 2016 12:33:21 +0000 (+0100)
Subject: linkchecker: Treat directory links as errors
X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=8e0baf492aeee89e927284b1bfd41c1af162ac3c;p=rust.git

linkchecker: Treat directory links as errors

Directory links don't work well offline so they should be treated as errors.
---

diff --git a/src/tools/linkchecker/main.rs b/src/tools/linkchecker/main.rs
index a7c8c01fab8..c02fc8a3f91 100644
--- a/src/tools/linkchecker/main.rs
+++ b/src/tools/linkchecker/main.rs
@@ -191,6 +191,12 @@ fn check(cache: &mut Cache,
         // exist! If it doesn't then we register and print an error.
         if path.exists() {
             if path.is_dir() {
+                // Links to directories show as directory listings when viewing
+                // the docs offline so it's best to avoid them.
+                *errors = true;
+                let pretty_path = path.strip_prefix(root).unwrap_or(&path);
+                println!("{}:{}: directory link - {}", pretty_file.display(),
+                         i + 1, pretty_path.display());
                 return;
             }
             let res = load_file(cache, root, path.clone(), FromRedirect(false));