From: Eric Huss <eric@huss.org>
Date: Thu, 23 May 2019 20:33:08 +0000 (-0700)
Subject: tidy: don't short-circuit on license error
X-Git-Url: https://git.lizzy.rs/?a=commitdiff_plain;h=46ffb6adbaed91a09d36953970078b0fae6de61f;p=rust.git

tidy: don't short-circuit on license error

If there is more than one license error, tidy would only print the first
error. This changes it so that all license errors are printed.
---

diff --git a/src/tools/tidy/src/deps.rs b/src/tools/tidy/src/deps.rs
index 8626ba060bf..6f9623d18d2 100644
--- a/src/tools/tidy/src/deps.rs
+++ b/src/tools/tidy/src/deps.rs
@@ -241,7 +241,7 @@ pub fn check(path: &Path, bad: &mut bool) {
         }
 
         let toml = dir.path().join("Cargo.toml");
-        *bad = *bad || !check_license(&toml);
+        *bad = !check_license(&toml) || *bad;
     }
     assert!(saw_dir, "no vendored source");
 }