Properly strip windows binaries produced by CI

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index f50726cf6236d5059b6d5b309c97fd577d2142d0..5feea3e4ac19b5c722462c39aa6e16594ace06c0 100644 (file)
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -77,7 +77,7 @@ jobs:
       - uses: actions/upload-artifact@v2
         with:
           name: irrlicht-win32
-          path: ./irrlicht-windows.zip
+          path: ./irrlicht-win32.zip
 
   win64:
     runs-on: ubuntu-20.04
@@ -99,7 +99,7 @@ jobs:
       - uses: actions/upload-artifact@v2
         with:
           name: irrlicht-win64
-          path: ./irrlicht-windows.zip
+          path: ./irrlicht-win64.zip
 
   macos:
     runs-on: macos-10.15

diff --git a/scripts/ci-build-mingw.sh b/scripts/ci-build-mingw.sh
index e925c3942eb87153b44d1546cf1082f15e52a2c5..8173aa64bd29f91803192974ce843e16918b92f3 100755 (executable)
--- a/scripts/ci-build-mingw.sh
+++ b/scripts/ci-build-mingw.sh
@@ -34,15 +34,17 @@ tmp=(
        -DZLIB_LIBRARY=$libs/zlib/lib/libz.dll.a \
        -DZLIB_INCLUDE_DIR=$libs/zlib/include
 )
-[ "$1" = "package" ] && tmp+=(-DCMAKE_EXE_LINKER_FLAGS="-s")
 
 cmake . "${tmp[@]}"
 make -j$(nproc)
 
 if [ "$1" = "package" ]; then
        make DESTDIR=$PWD/_install install
+       # strip library
+       "${CXX%-*}-strip" --strip-unneeded _install/usr/local/lib/*.dll
        # bundle the DLLs that are specific to Irrlicht (kind of a hack)
        cp -p $libs/*/bin/lib{jpeg,png}*.dll _install/usr/local/lib/
-       (cd _install/usr/local; zip -9r "$OLDPWD"/irrlicht-windows.zip -- *)
+       # create a ZIP
+       (cd _install/usr/local; zip -9r "$OLDPWD"/irrlicht-$variant.zip -- *)
 fi
 exit 0