]> git.lizzy.rs Git - rust.git/commitdiff
Refactor code so the call to codemap.files() does not deadlock
authorJohn Kåre Alsaker <john.kare.alsaker@gmail.com>
Sun, 3 Dec 2017 13:08:21 +0000 (14:08 +0100)
committerJohn Kåre Alsaker <john.kare.alsaker@gmail.com>
Thu, 21 Dec 2017 18:21:40 +0000 (19:21 +0100)
src/librustc/ich/caching_codemap_view.rs

index e393459027859a741d86de7ff4ec63dd2bcad3a4..3caf308d6526842e746b7d5b9dc7f8601a7847a7 100644 (file)
@@ -78,11 +78,9 @@ pub fn byte_pos_to_line_and_col(&mut self,
         // If the entry doesn't point to the correct file, fix it up
         if pos < cache_entry.file.start_pos || pos >= cache_entry.file.end_pos {
             let file_valid;
-            let files = self.codemap.files();
-
-            if files.len() > 0 {
+            if self.codemap.files().len() > 0 {
                 let file_index = self.codemap.lookup_filemap_idx(pos);
-                let file = files[file_index].clone();
+                let file = self.codemap.files()[file_index].clone();
 
                 if pos >= file.start_pos && pos < file.end_pos {
                     cache_entry.file = file;