Make useless_attribute suggestion MaybeIncorrect

diff --git a/clippy_lints/src/attrs.rs b/clippy_lints/src/attrs.rs
index 1159df5475ac0bb3e1e8d6e1cec46cd46993db91..558298c2e0e0786bf756973b5c5915d3c9369584 100644 (file)
--- a/clippy_lints/src/attrs.rs
+++ b/clippy_lints/src/attrs.rs
@@ -277,7 +277,7 @@ fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
                                                         line_span,
                                                         "if you just forgot a `!`, use",
                                                         sugg,
-                                                        Applicability::MachineApplicable,
+                                                        Applicability::MaybeIncorrect,
                                                     );
                                                 },
                                             );

diff --git a/tests/ui/useless_attribute.fixed b/tests/ui/useless_attribute.fixed
deleted file mode 100644 (file)
index d729311..0000000
--- a/tests/ui/useless_attribute.fixed
+++ /dev/null
@@ -1,49 +0,0 @@
-// run-rustfix
-// aux-build:proc_macro_derive.rs
-
-#![warn(clippy::useless_attribute)]
-#![warn(unreachable_pub)]
-
-#![allow(dead_code)]
-#![cfg_attr(feature = "cargo-clippy", allow(dead_code))]
-#[rustfmt::skip]
-#[cfg_attr(feature = "cargo-clippy",
-           allow(dead_code))]
-#[allow(unused_imports)]
-#[allow(unused_extern_crates)]
-#[macro_use]
-extern crate clippy_lints;
-
-#[macro_use]
-extern crate proc_macro_derive;
-
-// don't lint on unused_import for `use` items
-#[allow(unused_imports)]
-use std::collections;
-
-// don't lint on deprecated for `use` items
-mod foo {
-    #[deprecated]
-    pub struct Bar;
-}
-#[allow(deprecated)]
-pub use foo::Bar;
-
-// This should not trigger the lint. There's lint level definitions inside the external derive
-// that would trigger the useless_attribute lint.
-#[derive(DeriveSomething)]
-struct Baz;
-
-// don't lint on unreachable_pub for `use` items
-mod a {
-    mod b {
-        #[allow(dead_code)]
-        #[allow(unreachable_pub)]
-        pub struct C {}
-    }
-
-    #[allow(unreachable_pub)]
-    pub use self::b::C;
-}
-
-fn main() {}

diff --git a/tests/ui/useless_attribute.rs b/tests/ui/useless_attribute.rs
index c6fc553112729f68c38fb6ba6355d933df979bb7..dd84b1b2c1c381570d276a43aa052d45b7cb01db 100644 (file)
--- a/tests/ui/useless_attribute.rs
+++ b/tests/ui/useless_attribute.rs
@@ -1,4 +1,3 @@
-// run-rustfix
 // aux-build:proc_macro_derive.rs
 
 #![warn(clippy::useless_attribute)]

diff --git a/tests/ui/useless_attribute.stderr b/tests/ui/useless_attribute.stderr
index 87a1291543e158da0a3edb6d01d2bf4381519bcd..bf7ea1698d354b42de59879ff204fc145cf5ad6d 100644 (file)
--- a/tests/ui/useless_attribute.stderr
+++ b/tests/ui/useless_attribute.stderr
@@ -1,5 +1,5 @@
 error: useless lint attribute
-  --> $DIR/useless_attribute.rs:7:1
+  --> $DIR/useless_attribute.rs:6:1
    |
 LL | #[allow(dead_code)]
    | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
@@ -7,7 +7,7 @@ LL | #[allow(dead_code)]
    = note: `-D clippy::useless-attribute` implied by `-D warnings`
 
 error: useless lint attribute
-  --> $DIR/useless_attribute.rs:8:1
+  --> $DIR/useless_attribute.rs:7:1
    |
 LL | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code)`