]> git.lizzy.rs Git - rust.git/commitdiff
Only call default steps once, not once for each PathSet
authorJoshua Nelson <jnelson@cloudflare.com>
Sun, 19 Jun 2022 22:25:20 +0000 (17:25 -0500)
committerJoshua Nelson <jnelson@cloudflare.com>
Sun, 26 Jun 2022 09:46:02 +0000 (04:46 -0500)
Running steps multiple times defeats the whole point of #96501,
since lint messages will be duplicated.

src/bootstrap/builder.rs

index 62b5416cee8af011605dd4ff05011826ad4f9161..d58829721cc9a90810bef11c2bea8ed603219837 100644 (file)
@@ -304,9 +304,7 @@ fn run(v: &[StepDescription], builder: &Builder<'_>, paths: &[PathBuf]) {
         if paths.is_empty() || builder.config.include_default_paths {
             for (desc, should_run) in v.iter().zip(&should_runs) {
                 if desc.default && should_run.is_really_default() {
-                    for pathset in &should_run.paths {
-                        desc.maybe_run(builder, vec![pathset.clone()]);
-                    }
+                    desc.maybe_run(builder, should_run.paths.iter().cloned().collect());
                 }
             }
         }