Naming

diff --git a/crates/flycheck/src/lib.rs b/crates/flycheck/src/lib.rs
index 0d68fcd4d3b0ed94ca57797be84aa86fadc507f7..073bcc9aec26a0b554e626e5c50dd9378642b47c 100644 (file)
--- a/crates/flycheck/src/lib.rs
+++ b/crates/flycheck/src/lib.rs
@@ -50,7 +50,7 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 #[derive(Debug)]
 pub struct FlycheckHandle {
     // XXX: drop order is significant
-    cmd_send: Sender<Restart>,
+    sender: Sender<Restart>,
     thread: jod_thread::JoinHandle,
 }
 
@@ -60,16 +60,15 @@ pub fn spawn(
         config: FlycheckConfig,
         workspace_root: PathBuf,
     ) -> FlycheckHandle {
-        let (cmd_send, cmd_recv) = unbounded::<Restart>();
-        let thread = jod_thread::spawn(move || {
-            FlycheckActor::new(sender, config, workspace_root).run(cmd_recv);
-        });
-        FlycheckHandle { cmd_send, thread }
+        let actor = FlycheckActor::new(sender, config, workspace_root);
+        let (sender, receiver) = unbounded::<Restart>();
+        let thread = jod_thread::spawn(move || actor.run(receiver));
+        FlycheckHandle { sender, thread }
     }
 
     /// Schedule a re-start of the cargo check worker.
     pub fn update(&self) {
-        self.cmd_send.send(Restart).unwrap();
+        self.sender.send(Restart).unwrap();
     }
 }
 
@@ -125,7 +124,7 @@ fn next_event(&self, inbox: &Receiver<Restart>) -> Option<Event> {
             recv(check_chan.unwrap_or(&never())) -> msg => Some(Event::CheckEvent(msg.ok())),
         }
     }
-    fn run(&mut self, inbox: Receiver<Restart>) {
+    fn run(mut self, inbox: Receiver<Restart>) {
         while let Some(event) = self.next_event(&inbox) {
             match event {
                 Event::Restart(Restart) => {

diff --git a/crates/vfs-notify/src/lib.rs b/crates/vfs-notify/src/lib.rs
index 25ba8d7982dd3fee97150198c4e2ea34d7d512f1..b1ea298ae5f6c891ecedec00215736411864dd5f 100644 (file)
--- a/crates/vfs-notify/src/lib.rs
+++ b/crates/vfs-notify/src/lib.rs
@@ -10,7 +10,7 @@
 
 use std::convert::{TryFrom, TryInto};
 
-use crossbeam_channel::{select, unbounded, Receiver};
+use crossbeam_channel::{select, unbounded, Receiver, Sender};
 use notify::{RecommendedWatcher, RecursiveMode, Watcher};
 use paths::{AbsPath, AbsPathBuf};
 use rustc_hash::FxHashSet;
@@ -22,8 +22,8 @@
 #[derive(Debug)]
 pub struct NotifyHandle {
     // Relative order of fields below is significant.
-    sender: crossbeam_channel::Sender<Message>,
-    _thread: jod_thread::JoinHandle,
+    sender: Sender<Message>,
+    thread: jod_thread::JoinHandle,
 }
 
 #[derive(Debug)]
@@ -37,7 +37,7 @@ fn spawn(sender: loader::Sender) -> NotifyHandle {
         let actor = NotifyActor::new(sender);
         let (sender, receiver) = unbounded::<Message>();
         let thread = jod_thread::spawn(move || actor.run(receiver));
-        NotifyHandle { sender, _thread: thread }
+        NotifyHandle { sender, thread }
     }
     fn set_config(&mut self, config: loader::Config) {
         self.sender.send(Message::Config(config)).unwrap()