extra: Address review comments from Jack

diff --git a/src/libextra/workcache.rs b/src/libextra/workcache.rs
index d5d37a30f6bd8e8161e7808c1e890b544de92b37..bbb8dbfcbfe5378bad1ba379157259b7abdea46c 100644 (file)
--- a/src/libextra/workcache.rs
+++ b/src/libextra/workcache.rs
@@ -296,9 +296,9 @@ pub fn new(db: RWArc<Database>,
     }
 
     pub fn new_with_freshness(db: RWArc<Database>,
-               lg: RWArc<Logger>,
-               cfg: Arc<json::Object>,
-               freshness: Arc<FreshnessMap>) -> Context {
+                              lg: RWArc<Logger>,
+                              cfg: Arc<json::Object>,
+                              freshness: Arc<FreshnessMap>) -> Context {
         Context {
             db: db,
             logger: lg,
@@ -319,16 +319,18 @@ pub fn with_prep<'a, T>(&'a self, fn_name: &'a str, blk: &fn(p: &mut Prep) -> T)
 }
 
 impl Exec {
-    pub fn discover_input(&mut self, dependency_kind:&str,
-       // Discovered input
-       dependency_name: &str, dependency_val: &str) {
+    pub fn discover_input(&mut self,
+                          dependency_kind: &str,
+                          dependency_name: &str,
+                          dependency_val: &str) {
         debug!("Discovering input %s %s %s", dependency_kind, dependency_name, dependency_val);
         self.discovered_inputs.insert_work_key(WorkKey::new(dependency_kind, dependency_name),
                                  dependency_val.to_owned());
     }
-    pub fn discover_output(&mut self, dependency_kind:&str,
-       // Discovered output
-       dependency_name: &str, dependency_val: &str) {
+    pub fn discover_output(&mut self,
+                           dependency_kind: &str,
+                           dependency_name: &str,
+                           dependency_val: &str) {
         debug!("Discovering output %s %s %s", dependency_kind, dependency_name, dependency_val);
         self.discovered_outputs.insert_work_key(WorkKey::new(dependency_kind, dependency_name),
                                  dependency_val.to_owned());
@@ -340,11 +342,10 @@ pub fn lookup_discovered_inputs(&self) -> ~[(~str, ~str)] {
         for (k, v) in self.discovered_inputs.iter() {
             for (k1, _) in v.iter() {
                 rs.push((k1.clone(), k.clone()));
-                }
+            }
         }
         rs
     }
-
 }
 
 impl<'self> Prep<'self> {
@@ -368,7 +369,7 @@ pub fn lookup_declared_inputs(&self) -> ~[~str] {
 }
 
 impl<'self> Prep<'self> {
-    pub fn declare_input(&mut self, kind:&str, name:&str, val:&str) {
+    pub fn declare_input(&mut self, kind: &str, name: &str, val: &str) {
         debug!("Declaring input %s %s %s", kind, name, val);
         self.declared_inputs.insert_work_key(WorkKey::new(kind, name),
                                  val.to_owned());