if let ExprBinary(ref cmp, _, ref right) = expr.node {
if let Spanned {node: BinOp_::BiRem, ..} = *cmp {
if is_integer_literal(right, 1) {
- cx.span_lint(MODULO_ONE, expr.span, "any number modulo 1 will be 0");
+ span_lint(cx, MODULO_ONE, expr.span, "any number modulo 1 will be 0");
}
}
}
fn check_pat(&mut self, cx: &LateContext, pat: &Pat) {
if let PatKind::Ident(_, ref ident, Some(ref right)) = pat.node {
if right.node == PatKind::Wild {
- cx.span_lint(REDUNDANT_PATTERN,
- pat.span,
- &format!("the `{} @ _` pattern can be written as just `{}`",
- ident.node.name,
- ident.node.name));
+ span_lint(cx,
+ REDUNDANT_PATTERN,
+ pat.span,
+ &format!("the `{} @ _` pattern can be written as just `{}`",
+ ident.node.name,
+ ident.node.name));
}
}
}
_ => false,
};
if needs_lint {
- cx.span_lint(USED_UNDERSCORE_BINDING,
- expr.span,
- "used binding which is prefixed with an underscore. A leading underscore signals that a \
- binding will not be used.");
+ span_lint(cx,
+ USED_UNDERSCORE_BINDING,
+ expr.span,
+ "used binding which is prefixed with an underscore. A leading underscore signals that a \
+ binding will not be used.");
}
}
}
use rustc::lint::*;
use rustc_front::hir::*;
use syntax::codemap::Spanned;
-use utils::{is_integer_literal, match_type, snippet, unsugar_range, UnsugaredRange};
+use utils::{is_integer_literal, match_type, snippet, span_lint, unsugar_range, UnsugaredRange};
/// **What it does:** This lint checks for iterating over ranges with a `.step_by(0)`, which never terminates.
///
// Range with step_by(0).
if name.as_str() == "step_by" && args.len() == 2 && is_range(cx, &args[0]) &&
is_integer_literal(&args[1], 0) {
- cx.span_lint(RANGE_STEP_BY_ZERO,
- expr.span,
- "Range::step_by(0) produces an infinite iterator. Consider using `std::iter::repeat()` \
- instead")
+ span_lint(cx,
+ RANGE_STEP_BY_ZERO,
+ expr.span,
+ "Range::step_by(0) produces an infinite iterator. Consider using `std::iter::repeat()` \
+ instead");
} else if name.as_str() == "zip" && args.len() == 2 {
let iter = &args[0].node;
let zip_arg = &args[1];
let ExprPath(_, Path { segments: ref len_path, .. }) = len_args[0].node,
iter_path == len_path
], {
- cx.span_lint(RANGE_ZIP_WITH_LEN, expr.span,
- &format!("It is more idiomatic to use {}.iter().enumerate()",
- snippet(cx, iter_args[0].span, "_")));
+ span_lint(cx,
+ RANGE_ZIP_WITH_LEN,
+ expr.span,
+ &format!("It is more idiomatic to use {}.iter().enumerate()",
+ snippet(cx, iter_args[0].span, "_")));
}
}
}