]> git.lizzy.rs Git - rust.git/commitdiff
Store a LocalDefId in hir::Variant & hir::Field.
authorCamille GILLOT <gillot.camille@gmail.com>
Sun, 6 Nov 2022 19:46:55 +0000 (19:46 +0000)
committerCamille GILLOT <gillot.camille@gmail.com>
Sun, 13 Nov 2022 14:06:51 +0000 (14:06 +0000)
clippy_lints/src/manual_non_exhaustive.rs
clippy_lints/src/missing_doc.rs

index 6806c1466968de17328ad8928f98fc9de8979505..4877cee0cc1ea8ea8bc3b575cb38272e84a94b17 100644 (file)
@@ -157,10 +157,10 @@ fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'_>) {
             && def.variants.len() > 1
         {
             let mut iter = def.variants.iter().filter_map(|v| {
-                let id = cx.tcx.hir().local_def_id(v.id);
-                (matches!(v.data, hir::VariantData::Unit(_))
+                let id = cx.tcx.hir().local_def_id(v.hir_id);
+                (matches!(v.data, hir::VariantData::Unit(..))
                     && v.ident.as_str().starts_with('_')
-                    && is_doc_hidden(cx.tcx.hir().attrs(v.id)))
+                    && is_doc_hidden(cx.tcx.hir().attrs(v.hir_id)))
                 .then_some((id, v.span))
             });
             if let Some((id, span)) = iter.next()
index 2a63681db60e55df076f5a3bc93d77f5f7f684a0..6fd100762b49dd7caacd956f9b6596f050d053db 100644 (file)
@@ -199,7 +199,7 @@ fn check_field_def(&mut self, cx: &LateContext<'tcx>, sf: &'tcx hir::FieldDef<'_
     }
 
     fn check_variant(&mut self, cx: &LateContext<'tcx>, v: &'tcx hir::Variant<'_>) {
-        let attrs = cx.tcx.hir().attrs(v.id);
+        let attrs = cx.tcx.hir().attrs(v.hir_id);
         if !is_from_proc_macro(cx, v) {
             self.check_missing_docs_attrs(cx, attrs, v.span, "a", "variant");
         }