Remove unnecessary comma

diff --git a/crates/assists/src/handlers/replace_impl_trait_with_generic.rs b/crates/assists/src/handlers/replace_impl_trait_with_generic.rs
index 748c528d45acb263c73b28391b818d866ba8c2f9..6738bc13419dd219fc9c0e3ce03e78eb56dfba22 100644 (file)
--- a/crates/assists/src/handlers/replace_impl_trait_with_generic.rs
+++ b/crates/assists/src/handlers/replace_impl_trait_with_generic.rs
@@ -11,7 +11,7 @@
 // ```
 // ->
 // ```
-// fn foo<B: Bar,>(bar: B) {}
+// fn foo<B: Bar>(bar: B) {}
 // ```
 pub(crate) fn replace_impl_trait_with_generic(
     acc: &mut Assists,
@@ -59,7 +59,7 @@ fn replace_impl_trait_with_generic_params() {
             fn foo<G>(bar: <|>impl Bar) {}
             "#,
             r#"
-            fn foo<G, B: Bar,>(bar: B) {}
+            fn foo<G, B: Bar>(bar: B) {}
             "#,
         );
     }
@@ -72,7 +72,7 @@ fn replace_impl_trait_without_generic_params() {
             fn foo(bar: <|>impl Bar) {}
             "#,
             r#"
-            fn foo<B: Bar,>(bar: B) {}
+            fn foo<B: Bar>(bar: B) {}
             "#,
         );
     }
@@ -85,7 +85,7 @@ fn replace_two_impl_trait_with_generic_params() {
             fn foo<G>(foo: impl Foo, bar: <|>impl Bar) {}
             "#,
             r#"
-            fn foo<G, B: Bar,>(foo: impl Foo, bar: B) {}
+            fn foo<G, B: Bar>(foo: impl Foo, bar: B) {}
             "#,
         );
     }
@@ -98,7 +98,7 @@ fn replace_impl_trait_with_empty_generic_params() {
             fn foo<>(bar: <|>impl Bar) {}
             "#,
             r#"
-            fn foo<B: Bar,>(bar: B) {}
+            fn foo<B: Bar>(bar: B) {}
             "#,
         );
     }
@@ -112,7 +112,7 @@ fn foo<
             >(bar: <|>impl Bar) {}
             "#,
             r#"
-            fn foo<B: Bar,
+            fn foo<B: Bar
             >(bar: B) {}
             "#,
         );
@@ -127,7 +127,7 @@ fn replace_impl_trait_with_exist_generic_letter() {
             fn foo<B>(bar: <|>impl Bar) {}
             "#,
             r#"
-            fn foo<B, C: Bar,>(bar: C) {}
+            fn foo<B, C: Bar>(bar: C) {}
             "#,
         );
     }
@@ -147,7 +147,7 @@ fn foo<
             fn foo<
                 G: Foo,
                 F,
-                H, B: Bar,
+                H, B: Bar
             >(bar: B) {}
             "#,
         );
@@ -161,7 +161,7 @@ fn replace_impl_trait_multiple() {
             fn foo(bar: <|>impl Foo + Bar) {}
             "#,
             r#"
-            fn foo<F: Foo + Bar,>(bar: F) {}
+            fn foo<F: Foo + Bar>(bar: F) {}
             "#,
         );
     }

diff --git a/crates/assists/src/tests/generated.rs b/crates/assists/src/tests/generated.rs
index 4e5ca38251b5ed25907728ca02ee1ddb461304f3..27d15adb08a74aea3d0588b17cc177185f60f4e8 100644 (file)
--- a/crates/assists/src/tests/generated.rs
+++ b/crates/assists/src/tests/generated.rs
@@ -822,7 +822,7 @@ fn doctest_replace_impl_trait_with_generic() {
 fn foo(bar: <|>impl Bar) {}
 "#####,
         r#####"
-fn foo<B: Bar,>(bar: B) {}
+fn foo<B: Bar>(bar: B) {}
 "#####,
     )
 }

diff --git a/crates/syntax/src/ast/edit.rs b/crates/syntax/src/ast/edit.rs
index 5b5454c72d23479569ee73e58c418bdd95a85523..8b1c65dd6f149d01270a2d9257a86870845e9907 100644 (file)
--- a/crates/syntax/src/ast/edit.rs
+++ b/crates/syntax/src/ast/edit.rs
@@ -492,7 +492,6 @@ pub fn append_param(&self, item: ast::GenericParam) -> ast::GenericParamList {
             to_insert.push(space.into());
         }
         to_insert.push(item.syntax().clone().into());
-        to_insert.push(make::token(T![,]).into());
 
         macro_rules! after_l_angle {
             () => {{