]> git.lizzy.rs Git - rust.git/commitdiff
Remove unused category from macros.
authorCamille GILLOT <gillot.camille@gmail.com>
Sun, 11 Oct 2020 18:44:24 +0000 (20:44 +0200)
committerCamille GILLOT <gillot.camille@gmail.com>
Thu, 22 Oct 2020 20:43:38 +0000 (22:43 +0200)
compiler/rustc_macros/src/query.rs
compiler/rustc_middle/src/ty/query/plumbing.rs
compiler/rustc_middle/src/ty/query/stats.rs

index e7c054653accbd81de47e37af896a3cb0d71cd8d..df569566f76d5268316159367df12b18df7e7679 100644 (file)
@@ -190,7 +190,11 @@ fn parse(input: ParseStream<'_>) -> Result<Self> {
 }
 
 /// A named group containing queries.
+///
+/// For now, the name is not used any more, but the capability remains interesting for future
+/// developments of the query system.
 struct Group {
+    #[allow(unused)]
     name: Ident,
     queries: List<Query>,
 }
@@ -422,7 +426,6 @@ pub fn rustc_queries(input: TokenStream) -> TokenStream {
     let mut cached_queries = quote! {};
 
     for group in groups.0 {
-        let mut group_stream = quote! {};
         for mut query in group.queries.0 {
             let modifiers = process_modifiers(&mut query);
             let name = &query.name;
@@ -485,7 +488,7 @@ pub fn rustc_queries(input: TokenStream) -> TokenStream {
             let attribute_stream = quote! {#(#attributes),*};
             let doc_comments = query.doc_comments.iter();
             // Add the query to the group
-            group_stream.extend(quote! {
+            query_stream.extend(quote! {
                 #(#doc_comments)*
                 [#attribute_stream] fn #name: #name(#arg) #result,
             });
@@ -514,10 +517,6 @@ pub fn rustc_queries(input: TokenStream) -> TokenStream {
 
             add_query_description_impl(&query, modifiers, &mut query_description_stream);
         }
-        let name = &group.name;
-        query_stream.extend(quote! {
-            #name { #group_stream },
-        });
     }
 
     dep_node_force_stream.extend(quote! {
index df79c4c9601d9577f58809e404198a5f66c2fe5a..7c8e7cd0182d0b8fd601031bd09694c7481a0e93 100644 (file)
@@ -242,24 +242,14 @@ macro_rules! hash_result {
     };
 }
 
-macro_rules! define_queries {
-    (<$tcx:tt> $($category:tt {
-        $($(#[$attr:meta])* [$($modifiers:tt)*] fn $name:ident: $node:ident($($K:tt)*) -> $V:ty,)*
-    },)*) => {
-        define_queries_inner! { <$tcx>
-            $($( $(#[$attr])* category<$category> [$($modifiers)*] fn $name: $node($($K)*) -> $V,)*)*
-        }
-    }
-}
-
 macro_rules! query_helper_param_ty {
     (DefId) => { impl IntoQueryParam<DefId> };
     ($K:ty) => { $K };
 }
 
-macro_rules! define_queries_inner {
+macro_rules! define_queries {
     (<$tcx:tt>
-     $($(#[$attr:meta])* category<$category:tt>
+     $($(#[$attr:meta])*
         [$($modifiers:tt)*] fn $name:ident: $node:ident($($K:tt)*) -> $V:ty,)*) => {
 
         use std::mem;
index 877f88d380a39848cdb17be7277a7d68fee805a3..f6df83c912394b26dbb9645f844e730513a76cdc 100644 (file)
@@ -120,13 +120,13 @@ pub fn print_stats(tcx: TyCtxt<'_>) {
 }
 
 macro_rules! print_stats {
-    (<$tcx:tt> $($category:tt {
+    (<$tcx:tt>
         $($(#[$attr:meta])* [$($modifiers:tt)*] fn $name:ident: $node:ident($K:ty) -> $V:ty,)*
-    },)*) => {
+    ) => {
         fn query_stats(tcx: TyCtxt<'_>) -> Vec<QueryStats> {
             let mut queries = Vec::new();
 
-            $($(
+            $(
                 queries.push(stats::<
                     crate::dep_graph::DepKind,
                     <TyCtxt<'_> as QueryContext>::Query,
@@ -135,7 +135,7 @@ fn query_stats(tcx: TyCtxt<'_>) -> Vec<QueryStats> {
                     stringify!($name),
                     &tcx.queries.$name,
                 ));
-            )*)*
+            )*
 
             queries
         }