]> git.lizzy.rs Git - rust.git/commitdiff
Fix LLVM assertion when out-of-bounds indexing in a constant
authorBjörn Steinbrink <bsteinbr@gmail.com>
Wed, 11 Mar 2015 23:19:37 +0000 (00:19 +0100)
committerBjörn Steinbrink <bsteinbr@gmail.com>
Wed, 11 Mar 2015 23:38:22 +0000 (00:38 +0100)
Fixes #23291

src/librustc_trans/trans/consts.rs
src/test/compile-fail/const-array-oob.rs [new file with mode: 0644]

index 39b430b7ad51ed1a6ddcb5eaeaa9baea1311e89e..8dcabe0a94bb82f44887a9dc143f4bf1560c4671 100644 (file)
@@ -505,8 +505,10 @@ fn const_expr_unadjusted<'a, 'tcx>(cx: &CrateContext<'a, 'tcx>,
                   // pass. Reporting here is a bit late.
                   cx.sess().span_err(e.span,
                                      "const index-expr is out of bounds");
+                  C_undef(type_of::type_of(cx, bt).element_type())
+              } else {
+                  const_get_elt(cx, arr, &[iv as c_uint])
               }
-              const_get_elt(cx, arr, &[iv as c_uint])
           }
           ast::ExprCast(ref base, _) => {
             let llty = type_of::type_of(cx, ety);
diff --git a/src/test/compile-fail/const-array-oob.rs b/src/test/compile-fail/const-array-oob.rs
new file mode 100644 (file)
index 0000000..84d3529
--- /dev/null
@@ -0,0 +1,16 @@
+// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+const FOO: [u32; 3] = [1, 2, 3];
+const BAR: u32 = FOO[5]; //~ ERROR const index-expr is out of bounds
+
+fn main() {
+    let _ = BAR;
+}