]> git.lizzy.rs Git - rust.git/commitdiff
Replace some std::iter::repeat with str::repeat
authorr00ster91 <r00ster91@protonmail.com>
Fri, 4 Jun 2021 12:32:47 +0000 (14:32 +0200)
committerr00ster91 <r00ster91@protonmail.com>
Fri, 4 Jun 2021 12:32:47 +0000 (14:32 +0200)
clippy_lints/src/mem_discriminant.rs
clippy_lints/src/methods/clone_on_copy.rs

index a735c616f6e416fdeb06e0b8d6232875252b7a80..aca96e06ef2e779c9be14100770758b1ed88781e 100644 (file)
@@ -7,7 +7,6 @@
 use rustc_hir::{BorrowKind, Expr, ExprKind};
 use rustc_lint::{LateContext, LateLintPass};
 use rustc_session::{declare_lint_pass, declare_tool_lint};
-use std::iter;
 
 declare_clippy_lint! {
     /// **What it does:** Checks for calls of `mem::discriminant()` on a non-enum type.
@@ -67,7 +66,7 @@ fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
                                 }
                             }
 
-                            let derefs: String = iter::repeat('*').take(derefs_needed).collect();
+                            let derefs = "*".repeat(derefs_needed);
                             diag.span_suggestion(
                                 param.span,
                                 "try dereferencing",
index ce2e8fa8b1074aaa8b9324a4554e6ff63b249658..1a32af5dc7a386fdd5e03c3832e8c105d6fc47f8 100644 (file)
@@ -8,7 +8,6 @@
 use rustc_lint::LateContext;
 use rustc_middle::ty::{self, adjustment::Adjust};
 use rustc_span::symbol::{sym, Symbol};
-use std::iter;
 
 use super::CLONE_DOUBLE_REF;
 use super::CLONE_ON_COPY;
@@ -54,8 +53,8 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>, method_name: Symbol,
                             ty = inner;
                             n += 1;
                         }
-                        let refs: String = iter::repeat('&').take(n + 1).collect();
-                        let derefs: String = iter::repeat('*').take(n).collect();
+                        let refs = "&".repeat(n + 1);
+                        let derefs = "*".repeat(n);
                         let explicit = format!("<{}{}>::clone({})", refs, ty, snip);
                         diag.span_suggestion(
                             expr.span,