]> git.lizzy.rs Git - rust.git/commitdiff
use std::mem::take(x) instead of std::mem::replace(x, Default::default()) (clippy...
authorMatthias Krüger <matthias.krueger@famsik.de>
Mon, 21 Sep 2020 23:32:28 +0000 (01:32 +0200)
committerMatthias Krüger <matthias.krueger@famsik.de>
Thu, 24 Sep 2020 11:38:08 +0000 (13:38 +0200)
compiler/rustc_mir/src/borrow_check/type_check/constraint_conversion.rs
compiler/rustc_typeck/src/check/writeback.rs

index 711271a63fbff2c3cd853b37dc6a555207ebc0b7..8513e5e531bd7e88b7cfe607fc6c43800a908a2c 100644 (file)
@@ -62,8 +62,7 @@ pub(super) fn convert_all(&mut self, query_constraints: &QueryRegionConstraints<
         // `self.constraints`, but we also want to be mutating
         // `self.member_constraints`. For now, just swap out the value
         // we want and replace at the end.
-        let mut tmp =
-            std::mem::replace(&mut self.constraints.member_constraints, Default::default());
+        let mut tmp = std::mem::take(&mut self.constraints.member_constraints);
         for member_constraint in member_constraints {
             tmp.push_constraint(member_constraint, |r| self.to_region_vid(r));
         }
index b55f62ee436e1ab7493bea047bee2f7ad01c60bd..df7cdae46dc30547250818d626b4882f0be2442f 100644 (file)
@@ -70,10 +70,8 @@ pub fn resolve_type_vars_in_body(
         debug!("used_trait_imports({:?}) = {:?}", item_def_id, used_trait_imports);
         wbcx.typeck_results.used_trait_imports = used_trait_imports;
 
-        wbcx.typeck_results.closure_captures = mem::replace(
-            &mut self.typeck_results.borrow_mut().closure_captures,
-            Default::default(),
-        );
+        wbcx.typeck_results.closure_captures =
+            mem::take(&mut self.typeck_results.borrow_mut().closure_captures);
 
         if self.is_tainted_by_errors() {
             // FIXME(eddyb) keep track of `ErrorReported` from where the error was emitted.