]> git.lizzy.rs Git - rust.git/commitdiff
rustc: don't unpack newtypes of scalar-pairs with mismatched alignment.
authorEduard-Mihai Burtescu <edy.burt@gmail.com>
Fri, 1 Dec 2017 16:36:58 +0000 (18:36 +0200)
committerEduard-Mihai Burtescu <edy.burt@gmail.com>
Fri, 1 Dec 2017 22:29:56 +0000 (00:29 +0200)
src/librustc/ty/layout.rs
src/test/codegen/packed.rs

index 7d262adffdb989df46a792f1c73f141ecb7e3613..b2ed34cb91305ea9078af13cc087c0058ae35d60 100644 (file)
@@ -1079,7 +1079,9 @@ enum StructKind {
                         // We have exactly one non-ZST field.
                         (Some((i, field)), None, None) => {
                             // Field fills the struct and it has a scalar or scalar pair ABI.
-                            if offsets[i].bytes() == 0 && size == field.size {
+                            if offsets[i].bytes() == 0 &&
+                               align.abi() == field.align.abi() &&
+                               size == field.size {
                                 match field.abi {
                                     // For plain scalars we can't unpack newtypes
                                     // for `#[repr(C)]`, as that affects C ABIs.
index dd530cf03cd41f3d0a20dd613d096827ab9564eb..022f581278c2f9424f6dc51892e17abe1252cfe0 100644 (file)
@@ -57,3 +57,14 @@ pub fn pkd_pair(pair1: &mut PackedPair, pair2: &mut PackedPair) {
 // CHECK: call void @llvm.memcpy.{{.*}}(i8* %{{.*}}, i8* %{{.*}}, i{{[0-9]+}} 5, i32 1, i1 false)
     *pair2 = *pair1;
 }
+
+#[repr(packed)]
+#[derive(Copy, Clone)]
+pub struct PackedNestedPair((u32, u32));
+
+// CHECK-LABEL: @pkd_nested_pair
+#[no_mangle]
+pub fn pkd_nested_pair(pair1: &mut PackedNestedPair, pair2: &mut PackedNestedPair) {
+// CHECK: call void @llvm.memcpy.{{.*}}(i8* %{{.*}}, i8* %{{.*}}, i{{[0-9]+}} 8, i32 1, i1 false)
+    *pair2 = *pair1;
+}