]> git.lizzy.rs Git - rust.git/commitdiff
std: use a `match` in `assert_eq!` to extend the lifetime of the args.
authorHuon Wilson <dbau.pp+github@gmail.com>
Mon, 7 Apr 2014 12:32:49 +0000 (22:32 +1000)
committerHuon Wilson <dbau.pp+github@gmail.com>
Tue, 8 Apr 2014 23:57:49 +0000 (09:57 +1000)
This enables

    assert_eq!(foo.collect::<Vec<...>>().as_slice(), &[1,2,3,4]);

to work, by extending the lifetime of the .as_slice() rvalue.

src/libstd/macros.rs

index fbb48f2ebcb2641bcc3d02ad16893c8f3c18a634..9d06e38dd8e9caad47154f8d20f2e0bfebfca468 100644 (file)
@@ -117,13 +117,15 @@ macro_rules! assert(
 #[macro_export]
 macro_rules! assert_eq(
     ($given:expr , $expected:expr) => ({
-        let given_val = &($given);
-        let expected_val = &($expected);
-        // check both directions of equality....
-        if !((*given_val == *expected_val) &&
-             (*expected_val == *given_val)) {
-            fail!("assertion failed: `(left == right) && (right == left)` \
-                   (left: `{}`, right: `{}`)", *given_val, *expected_val)
+        match (&($given), &($expected)) {
+            (given_val, expected_val) => {
+                // check both directions of equality....
+                if !((*given_val == *expected_val) &&
+                     (*expected_val == *given_val)) {
+                    fail!("assertion failed: `(left == right) && (right == left)` \
+                           (left: `{}`, right: `{}`)", *given_val, *expected_val)
+                }
+            }
         }
     })
 )