}
ast::meta_list(na, la) {
+ // [Fixme-sorting]
// FIXME (#607): Needs implementing
// This involves probably sorting the list by name and
// meta_item variant
/* Higher-level applications */
// FIXME: This needs to sort by meta_item variant in addition to the item name
+// (See [Fixme-sorting])
fn sort_meta_items(items: [@ast::meta_item]) -> [@ast::meta_item] {
fn lteq(&&ma: @ast::meta_item, &&mb: @ast::meta_item) -> bool {
fn key(m: @ast::meta_item) -> ast::ident {
cx.span_fatal(sp, "malformed #env call");
}
// FIXME: if this was more thorough it would manufacture an
- // option<str> rather than just an maybe-empty string.
+ // option<str> rather than just an maybe-empty string. (Issue #2248)
let var = expr_to_str(cx, args[0], "#env requires a string");
alt os::getenv(var) {
// FIXME: this is a terrible kludge to inject some macros into the default
// compilation environment. When the macro-definition system is substantially
// more mature, these should move from here, into a compiled part of libcore
-// at very least.
+// at very least. (Issue #2247)
fn core_macros() -> str {
ret
// be factored out in common with other code that builds expressions.
// FIXME: Cleanup the naming of these functions
// NOTE: Moved many of the common ones to build.rs --kevina
+// See Issue #2249
fn pieces_to_expr(cx: ext_ctxt, sp: span, pieces: [piece], args: [@ast::expr])
-> @ast::expr {
fn make_path_vec(_cx: ext_ctxt, ident: ast::ident) -> [ast::ident] {
}
fn make_new_conv(cx: ext_ctxt, sp: span, cnv: conv, arg: @ast::expr) ->
@ast::expr {
- // FIXME: Extract all this validation into extfmt::ct
+ // FIXME: Move validation code into core::extfmt (Issue #2249)
fn is_signed_type(cnv: conv) -> bool {
alt cnv.ty {
}
}
}
- /* FIXME: handle embedded types and blocks, at least */
+ /* FIXME: handle embedded types and blocks, at least
+ (Issue #2251) */
expr_mac(mac) {
p_t_s_r_mac(cx, mac, s, b);
}
body: elts[1u]}];
// FIXME: check duplicates (or just simplify
- // the macro arg situation)
+ // the macro arg situation) (Issue #2251)
}
_ {
cx.span_bug(mac.span, "undocumented invariant in \