]> git.lizzy.rs Git - rust.git/commitdiff
Additional assumption to elide bounds check
authorDániel Buga <bugadani@gmail.com>
Sun, 30 Aug 2020 19:26:03 +0000 (21:26 +0200)
committerDániel Buga <bugadani@gmail.com>
Mon, 31 Aug 2020 06:19:15 +0000 (08:19 +0200)
compiler/rustc_codegen_ssa/src/mir/rvalue.rs

index 71f924df119a3ba6ebb47040dd051938e8f3c688..43521048012fafd1e13c7b3f294ff5eb767f8d10 100644 (file)
@@ -327,13 +327,29 @@ pub fn codegen_rvalue_operand(
                                 if er.end != er.start
                                     && scalar.valid_range.end() > scalar.valid_range.start()
                                 {
-                                    // We want `table[e as usize]` to not
+                                    // We want `table[e as usize ± k]` to not
                                     // have bound checks, and this is the most
-                                    // convenient place to put the `assume`.
-                                    let ll_t_in_const =
+                                    // convenient place to put the `assume`s.
+                                    if *scalar.valid_range.start() > 0 {
+                                        let enum_value_lower_bound = bx
+                                            .cx()
+                                            .const_uint_big(ll_t_in, *scalar.valid_range.start());
+                                        let cmp_start = bx.icmp(
+                                            IntPredicate::IntUGE,
+                                            llval,
+                                            enum_value_lower_bound,
+                                        );
+                                        bx.assume(cmp_start);
+                                    }
+
+                                    let enum_value_upper_bound =
                                         bx.cx().const_uint_big(ll_t_in, *scalar.valid_range.end());
-                                    let cmp = bx.icmp(IntPredicate::IntULE, llval, ll_t_in_const);
-                                    bx.assume(cmp);
+                                    let cmp_end = bx.icmp(
+                                        IntPredicate::IntULE,
+                                        llval,
+                                        enum_value_upper_bound,
+                                    );
+                                    bx.assume(cmp_end);
                                 }
                             }
                         }