]> git.lizzy.rs Git - rust.git/commitdiff
Auto merge of #105752 - chenyukang:yukang/refactor-method-error, r=compiler-errors
authorbors <bors@rust-lang.org>
Tue, 3 Jan 2023 20:44:40 +0000 (20:44 +0000)
committerbors <bors@rust-lang.org>
Tue, 3 Jan 2023 20:44:40 +0000 (20:44 +0000)
Refactoring report_method_error

While working on #105732, I found it's hard to follow this long function,
so I tried to make it shorter.

It's not easy for code reviewing, since so many lines of code changes,
but only the positions are changed.

Generally, I extract two sub-methods from `report_method_error`:

https://github.com/rust-lang/rust/blob/397b66e77b279de5006facf87979f9ecff5c7f87/compiler/rustc_hir_typeck/src/method/suggest.rs#L117
to `note_candidates_on_method_error`

And this long block:
https://github.com/rust-lang/rust/blob/397b66e77b279de5006facf87979f9ecff5c7f87/compiler/rustc_hir_typeck/src/method/suggest.rs#L263

to `report_no_match_method_error`.

r? `@compiler-errors`


Trivial merge