]> git.lizzy.rs Git - rust.git/commitdiff
Delete Decoder::read_enum
authorMark Rousskov <mark.simulacrum@gmail.com>
Wed, 9 Feb 2022 22:10:45 +0000 (17:10 -0500)
committerMark Rousskov <mark.simulacrum@gmail.com>
Sun, 20 Feb 2022 23:58:22 +0000 (18:58 -0500)
compiler/rustc_macros/src/serialize.rs
compiler/rustc_serialize/src/serialize.rs

index 6c5461505fa268b6bfd183d3c72edf845d82f1db..91a076fa6f624f9938e3b7ef299fe260a5a21987 100644 (file)
@@ -73,20 +73,15 @@ fn decodable_body(
                 variants.len()
             );
             quote! {
-                ::rustc_serialize::Decoder::read_enum(
+                ::rustc_serialize::Decoder::read_enum_variant(
                     __decoder,
-                    |__decoder| {
-                        ::rustc_serialize::Decoder::read_enum_variant(
-                            __decoder,
-                            &[#names],
-                            |__decoder, __variant_idx| {
-                                match __variant_idx {
-                                    #match_inner
-                                    _ => panic!(#message),
-                                }
-                            })
-                    }
-                )
+                    &[#names],
+                    |__decoder, __variant_idx| {
+                        match __variant_idx {
+                            #match_inner
+                            _ => panic!(#message),
+                        }
+                    })
             }
         }
     };
index a6172403fd63d91633a5448f2d578f177c2e8338..6e0199260f830955a7bdfdbc9c5dadb3f5ce3c4c 100644 (file)
@@ -201,15 +201,6 @@ pub trait Decoder {
     fn read_str(&mut self) -> Cow<'_, str>;
     fn read_raw_bytes_into(&mut self, s: &mut [u8]);
 
-    // Compound types:
-    #[inline]
-    fn read_enum<T, F>(&mut self, f: F) -> T
-    where
-        F: FnOnce(&mut Self) -> T,
-    {
-        f(self)
-    }
-
     #[inline]
     fn read_enum_variant<T, F>(&mut self, _names: &[&str], mut f: F) -> T
     where
@@ -264,12 +255,10 @@ fn read_option<T, F>(&mut self, mut f: F) -> T
     where
         F: FnMut(&mut Self, bool) -> T,
     {
-        self.read_enum(move |this| {
-            this.read_enum_variant(&["None", "Some"], move |this, idx| match idx {
-                0 => f(this, false),
-                1 => f(this, true),
-                _ => panic!("read_option: expected 0 for None or 1 for Some"),
-            })
+        self.read_enum_variant(&["None", "Some"], move |this, idx| match idx {
+            0 => f(this, false),
+            1 => f(this, true),
+            _ => panic!("read_option: expected 0 for None or 1 for Some"),
         })
     }
 
@@ -582,12 +571,10 @@ fn encode(&self, s: &mut S) -> Result<(), S::Error> {
 
 impl<D: Decoder, T1: Decodable<D>, T2: Decodable<D>> Decodable<D> for Result<T1, T2> {
     fn decode(d: &mut D) -> Result<T1, T2> {
-        d.read_enum(|d| {
-            d.read_enum_variant(&["Ok", "Err"], |d, disr| match disr {
-                0 => Ok(d.read_enum_variant_arg(|d| T1::decode(d))),
-                1 => Err(d.read_enum_variant_arg(|d| T2::decode(d))),
-                _ => panic!("Encountered invalid discriminant while decoding `Result`."),
-            })
+        d.read_enum_variant(&["Ok", "Err"], |d, disr| match disr {
+            0 => Ok(d.read_enum_variant_arg(|d| T1::decode(d))),
+            1 => Err(d.read_enum_variant_arg(|d| T2::decode(d))),
+            _ => panic!("Encountered invalid discriminant while decoding `Result`."),
         })
     }
 }