]> git.lizzy.rs Git - rust.git/commitdiff
use `|=`
authorNiko Matsakis <niko@alum.mit.edu>
Fri, 27 Aug 2021 21:13:41 +0000 (17:13 -0400)
committerNiko Matsakis <niko@alum.mit.edu>
Fri, 27 Aug 2021 21:13:41 +0000 (17:13 -0400)
compiler/rustc_typeck/src/expr_use_visitor.rs

index d999c17b579bb353b1b5b9d7b66df909b0742fe5..1c60ef7bda0d1106068c9127bdea4a00e12216ac 100644 (file)
@@ -262,12 +262,14 @@ pub fn walk_expr(&mut self, expr: &hir::Expr<'_>) {
                                     | Res::Def(DefKind::AssocConst, _) => {
                                         // Named constants have to be equated with the value
                                         // being matched, so that's a read of the value being matched.
+                                        //
+                                        // FIXME: We don't actually  reads for ZSTs.
                                         needs_to_be_read = true;
                                     }
                                     _ => {
                                         // Otherwise, this is a struct/enum variant, and so it's
                                         // only a read if we need to read the discriminant.
-                                        needs_to_be_read = is_multivariant_adt(place.place.ty());
+                                        needs_to_be_read |= is_multivariant_adt(place.place.ty());
                                     }
                                 }
                             }
@@ -279,9 +281,7 @@ pub fn walk_expr(&mut self, expr: &hir::Expr<'_>) {
                                 // perform some reads).
 
                                 let place_ty = place.place.ty();
-                                if is_multivariant_adt(place_ty) {
-                                    needs_to_be_read = true;
-                                }
+                                needs_to_be_read |= is_multivariant_adt(place_ty);
                             }
                             PatKind::Lit(_) | PatKind::Range(..) => {
                                 // If the PatKind is a Lit or a Range then we want