[`result_unwrap_used`]: https://rust-lang.github.io/rust-clippy/master/index.html#result_unwrap_used
[`return_self_not_must_use`]: https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use
[`reversed_empty_ranges`]: https://rust-lang.github.io/rust-clippy/master/index.html#reversed_empty_ranges
-[`rewind_instead_of_seek_to_start`]: https://rust-lang.github.io/rust-clippy/master/index.html#rewind_instead_of_seek_to_start
[`same_functions_in_if_condition`]: https://rust-lang.github.io/rust-clippy/master/index.html#same_functions_in_if_condition
[`same_item_push`]: https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push
[`same_name_method`]: https://rust-lang.github.io/rust-clippy/master/index.html#same_name_method
[`search_is_some`]: https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
+[`seek_to_start_instead_of_rewind`]: https://rust-lang.github.io/rust-clippy/master/index.html#seek_to_start_instead_of_rewind
[`self_assignment`]: https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment
[`self_named_constructors`]: https://rust-lang.github.io/rust-clippy/master/index.html#self_named_constructors
[`self_named_module_files`]: https://rust-lang.github.io/rust-clippy/master/index.html#self_named_module_files
crate::methods::RANGE_ZIP_WITH_LEN_INFO,
crate::methods::REPEAT_ONCE_INFO,
crate::methods::RESULT_MAP_OR_INTO_OPTION_INFO,
- crate::methods::REWIND_INSTEAD_OF_SEEK_TO_START_INFO,
crate::methods::SEARCH_IS_SOME_INFO,
+ crate::methods::SEEK_TO_START_INSTEAD_OF_REWIND_INFO,
crate::methods::SHOULD_IMPLEMENT_TRAIT_INFO,
crate::methods::SINGLE_CHAR_ADD_STR_INFO,
crate::methods::SINGLE_CHAR_PATTERN_INFO,
mod path_buf_push_overwrite;
mod range_zip_with_len;
mod repeat_once;
-mod rewind_instead_of_seek_to_start;
mod search_is_some;
+mod seek_to_start_instead_of_rewind;
mod single_char_add_str;
mod single_char_insert_string;
mod single_char_pattern;
/// }
/// ```
#[clippy::version = "1.66.0"]
- pub REWIND_INSTEAD_OF_SEEK_TO_START,
+ pub SEEK_TO_START_INSTEAD_OF_REWIND,
complexity,
"jumping to the start of stream using `seek` method"
}
VEC_RESIZE_TO_ZERO,
VERBOSE_FILE_READS,
ITER_KV_MAP,
- REWIND_INSTEAD_OF_SEEK_TO_START,
+ SEEK_TO_START_INSTEAD_OF_REWIND,
]);
/// Extracts a method call name, args, and `Span` of the method name.
},
("seek", [arg]) => {
if meets_msrv(self.msrv, msrvs::SEEK_REWIND) {
- rewind_instead_of_seek_to_start::check(cx, expr, recv, arg, span);
+ seek_to_start_instead_of_rewind::check(cx, expr, recv, arg, span);
}
},
("sort", []) => {
+++ /dev/null
-use clippy_utils::diagnostics::span_lint_and_then;
-use clippy_utils::ty::implements_trait;
-use clippy_utils::{get_trait_def_id, match_def_path, paths};
-use rustc_ast::ast::{LitIntType, LitKind};
-use rustc_errors::Applicability;
-use rustc_hir::{Expr, ExprKind};
-use rustc_lint::LateContext;
-use rustc_span::Span;
-
-use super::REWIND_INSTEAD_OF_SEEK_TO_START;
-
-pub(super) fn check<'tcx>(
- cx: &LateContext<'tcx>,
- expr: &'tcx Expr<'_>,
- recv: &'tcx Expr<'_>,
- arg: &'tcx Expr<'_>,
- name_span: Span,
-) {
- // Get receiver type
- let ty = cx.typeck_results().expr_ty(recv).peel_refs();
-
- if let Some(seek_trait_id) = get_trait_def_id(cx, &paths::STD_IO_SEEK) &&
- implements_trait(cx, ty, seek_trait_id, &[]) &&
- let ExprKind::Call(func, args1) = arg.kind &&
- let ExprKind::Path(ref path) = func.kind &&
- let Some(def_id) = cx.qpath_res(path, func.hir_id).opt_def_id() &&
- match_def_path(cx, def_id, &paths::STD_IO_SEEKFROM_START) &&
- args1.len() == 1 &&
- let ExprKind::Lit(ref lit) = args1[0].kind &&
- let LitKind::Int(0, LitIntType::Unsuffixed) = lit.node
- {
- let method_call_span = expr.span.with_lo(name_span.lo());
- span_lint_and_then(
- cx,
- REWIND_INSTEAD_OF_SEEK_TO_START,
- method_call_span,
- "used `seek` to go to the start of the stream",
- |diag| {
- let app = Applicability::MachineApplicable;
-
- diag.span_suggestion(method_call_span, "replace with", "rewind()", app);
- },
- );
- }
-}
--- /dev/null
+use clippy_utils::diagnostics::span_lint_and_then;
+use clippy_utils::ty::implements_trait;
+use clippy_utils::{get_trait_def_id, match_def_path, paths};
+use rustc_ast::ast::{LitIntType, LitKind};
+use rustc_errors::Applicability;
+use rustc_hir::{Expr, ExprKind};
+use rustc_lint::LateContext;
+use rustc_span::Span;
+
+use super::SEEK_TO_START_INSTEAD_OF_REWIND;
+
+pub(super) fn check<'tcx>(
+ cx: &LateContext<'tcx>,
+ expr: &'tcx Expr<'_>,
+ recv: &'tcx Expr<'_>,
+ arg: &'tcx Expr<'_>,
+ name_span: Span,
+) {
+ // Get receiver type
+ let ty = cx.typeck_results().expr_ty(recv).peel_refs();
+
+ if let Some(seek_trait_id) = get_trait_def_id(cx, &paths::STD_IO_SEEK) &&
+ implements_trait(cx, ty, seek_trait_id, &[]) &&
+ let ExprKind::Call(func, args1) = arg.kind &&
+ let ExprKind::Path(ref path) = func.kind &&
+ let Some(def_id) = cx.qpath_res(path, func.hir_id).opt_def_id() &&
+ match_def_path(cx, def_id, &paths::STD_IO_SEEKFROM_START) &&
+ args1.len() == 1 &&
+ let ExprKind::Lit(ref lit) = args1[0].kind &&
+ let LitKind::Int(0, LitIntType::Unsuffixed) = lit.node
+ {
+ let method_call_span = expr.span.with_lo(name_span.lo());
+ span_lint_and_then(
+ cx,
+ SEEK_TO_START_INSTEAD_OF_REWIND,
+ method_call_span,
+ "used `seek` to go to the start of the stream",
+ |diag| {
+ let app = Applicability::MachineApplicable;
+
+ diag.span_suggestion(method_call_span, "replace with", "rewind()", app);
+ },
+ );
+ }
+}
+++ /dev/null
-### What it does
-
-Checks for jumps to the start of a stream that implements `Seek`
-and uses the `seek` method providing `Start` as parameter.
-
-### Why is this bad?
-
-Readability. There is a specific method that was implemented for
-this exact scenario.
-
-### Example
-```
-fn foo<T: io::Seek>(t: &mut T) {
- t.seek(io::SeekFrom::Start(0));
-}
-```
-Use instead:
-```
-fn foo<T: io::Seek>(t: &mut T) {
- t.rewind();
-}
-```
\ No newline at end of file
--- /dev/null
+### What it does
+
+Checks for jumps to the start of a stream that implements `Seek`
+and uses the `seek` method providing `Start` as parameter.
+
+### Why is this bad?
+
+Readability. There is a specific method that was implemented for
+this exact scenario.
+
+### Example
+```
+fn foo<T: io::Seek>(t: &mut T) {
+ t.seek(io::SeekFrom::Start(0));
+}
+```
+Use instead:
+```
+fn foo<T: io::Seek>(t: &mut T) {
+ t.rewind();
+}
+```
\ No newline at end of file
+++ /dev/null
-// run-rustfix
-#![allow(unused)]
-#![feature(custom_inner_attributes)]
-#![warn(clippy::rewind_instead_of_seek_to_start)]
-
-use std::fs::OpenOptions;
-use std::io::{Read, Seek, SeekFrom, Write};
-
-struct StructWithSeekMethod {}
-
-impl StructWithSeekMethod {
- fn seek(&mut self, from: SeekFrom) {}
-}
-
-trait MySeekTrait {
- fn seek(&mut self, from: SeekFrom) {}
-}
-
-struct StructWithSeekTrait {}
-impl MySeekTrait for StructWithSeekTrait {}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_false_method(t: &mut StructWithSeekMethod) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_method_owned_false<T>(mut t: StructWithSeekMethod) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_false_trait(t: &mut StructWithSeekTrait) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_false_trait_owned<T>(mut t: StructWithSeekTrait) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_false_trait_bound<T: MySeekTrait>(t: &mut T) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should trigger clippy warning
-fn seek_to_start<T: Seek>(t: &mut T) {
- t.rewind();
-}
-
-// This should trigger clippy warning
-fn owned_seek_to_start<T: Seek>(mut t: T) {
- t.rewind();
-}
-
-// This should NOT trigger clippy warning because
-// it does not seek to start
-fn seek_to_5<T: Seek>(t: &mut T) {
- t.seek(SeekFrom::Start(5));
-}
-
-// This should NOT trigger clippy warning because
-// it does not seek to start
-fn seek_to_end<T: Seek>(t: &mut T) {
- t.seek(SeekFrom::End(0));
-}
-
-fn main() {
- let mut f = OpenOptions::new()
- .write(true)
- .read(true)
- .create(true)
- .open("foo.txt")
- .unwrap();
-
- let mut my_struct_trait = StructWithSeekTrait {};
- seek_to_start_false_trait_bound(&mut my_struct_trait);
-
- let hello = "Hello!\n";
- write!(f, "{hello}").unwrap();
- seek_to_5(&mut f);
- seek_to_end(&mut f);
- seek_to_start(&mut f);
-
- let mut buf = String::new();
- f.read_to_string(&mut buf).unwrap();
-
- assert_eq!(&buf, hello);
-}
-
-fn msrv_1_54() {
- #![clippy::msrv = "1.54"]
-
- let mut f = OpenOptions::new()
- .write(true)
- .read(true)
- .create(true)
- .open("foo.txt")
- .unwrap();
-
- let hello = "Hello!\n";
- write!(f, "{hello}").unwrap();
-
- f.seek(SeekFrom::Start(0));
-
- let mut buf = String::new();
- f.read_to_string(&mut buf).unwrap();
-
- assert_eq!(&buf, hello);
-}
-
-fn msrv_1_55() {
- #![clippy::msrv = "1.55"]
-
- let mut f = OpenOptions::new()
- .write(true)
- .read(true)
- .create(true)
- .open("foo.txt")
- .unwrap();
-
- let hello = "Hello!\n";
- write!(f, "{hello}").unwrap();
-
- f.rewind();
-
- let mut buf = String::new();
- f.read_to_string(&mut buf).unwrap();
-
- assert_eq!(&buf, hello);
-}
+++ /dev/null
-// run-rustfix
-#![allow(unused)]
-#![feature(custom_inner_attributes)]
-#![warn(clippy::rewind_instead_of_seek_to_start)]
-
-use std::fs::OpenOptions;
-use std::io::{Read, Seek, SeekFrom, Write};
-
-struct StructWithSeekMethod {}
-
-impl StructWithSeekMethod {
- fn seek(&mut self, from: SeekFrom) {}
-}
-
-trait MySeekTrait {
- fn seek(&mut self, from: SeekFrom) {}
-}
-
-struct StructWithSeekTrait {}
-impl MySeekTrait for StructWithSeekTrait {}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_false_method(t: &mut StructWithSeekMethod) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_method_owned_false<T>(mut t: StructWithSeekMethod) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_false_trait(t: &mut StructWithSeekTrait) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_false_trait_owned<T>(mut t: StructWithSeekTrait) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should NOT trigger clippy warning because
-// StructWithSeekMethod does not implement std::io::Seek;
-fn seek_to_start_false_trait_bound<T: MySeekTrait>(t: &mut T) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should trigger clippy warning
-fn seek_to_start<T: Seek>(t: &mut T) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should trigger clippy warning
-fn owned_seek_to_start<T: Seek>(mut t: T) {
- t.seek(SeekFrom::Start(0));
-}
-
-// This should NOT trigger clippy warning because
-// it does not seek to start
-fn seek_to_5<T: Seek>(t: &mut T) {
- t.seek(SeekFrom::Start(5));
-}
-
-// This should NOT trigger clippy warning because
-// it does not seek to start
-fn seek_to_end<T: Seek>(t: &mut T) {
- t.seek(SeekFrom::End(0));
-}
-
-fn main() {
- let mut f = OpenOptions::new()
- .write(true)
- .read(true)
- .create(true)
- .open("foo.txt")
- .unwrap();
-
- let mut my_struct_trait = StructWithSeekTrait {};
- seek_to_start_false_trait_bound(&mut my_struct_trait);
-
- let hello = "Hello!\n";
- write!(f, "{hello}").unwrap();
- seek_to_5(&mut f);
- seek_to_end(&mut f);
- seek_to_start(&mut f);
-
- let mut buf = String::new();
- f.read_to_string(&mut buf).unwrap();
-
- assert_eq!(&buf, hello);
-}
-
-fn msrv_1_54() {
- #![clippy::msrv = "1.54"]
-
- let mut f = OpenOptions::new()
- .write(true)
- .read(true)
- .create(true)
- .open("foo.txt")
- .unwrap();
-
- let hello = "Hello!\n";
- write!(f, "{hello}").unwrap();
-
- f.seek(SeekFrom::Start(0));
-
- let mut buf = String::new();
- f.read_to_string(&mut buf).unwrap();
-
- assert_eq!(&buf, hello);
-}
-
-fn msrv_1_55() {
- #![clippy::msrv = "1.55"]
-
- let mut f = OpenOptions::new()
- .write(true)
- .read(true)
- .create(true)
- .open("foo.txt")
- .unwrap();
-
- let hello = "Hello!\n";
- write!(f, "{hello}").unwrap();
-
- f.seek(SeekFrom::Start(0));
-
- let mut buf = String::new();
- f.read_to_string(&mut buf).unwrap();
-
- assert_eq!(&buf, hello);
-}
+++ /dev/null
-error: used `seek` to go to the start of the stream
- --> $DIR/rewind_instead_of_seek_to_start.rs:54:7
- |
-LL | t.seek(SeekFrom::Start(0));
- | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `rewind()`
- |
- = note: `-D clippy::rewind-instead-of-seek-to-start` implied by `-D warnings`
-
-error: used `seek` to go to the start of the stream
- --> $DIR/rewind_instead_of_seek_to_start.rs:59:7
- |
-LL | t.seek(SeekFrom::Start(0));
- | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `rewind()`
-
-error: used `seek` to go to the start of the stream
- --> $DIR/rewind_instead_of_seek_to_start.rs:131:7
- |
-LL | f.seek(SeekFrom::Start(0));
- | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `rewind()`
-
-error: aborting due to 3 previous errors
-
--- /dev/null
+// run-rustfix
+#![allow(unused)]
+#![feature(custom_inner_attributes)]
+#![warn(clippy::seek_to_start_instead_of_rewind)]
+
+use std::fs::OpenOptions;
+use std::io::{Read, Seek, SeekFrom, Write};
+
+struct StructWithSeekMethod {}
+
+impl StructWithSeekMethod {
+ fn seek(&mut self, from: SeekFrom) {}
+}
+
+trait MySeekTrait {
+ fn seek(&mut self, from: SeekFrom) {}
+}
+
+struct StructWithSeekTrait {}
+impl MySeekTrait for StructWithSeekTrait {}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_false_method(t: &mut StructWithSeekMethod) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_method_owned_false<T>(mut t: StructWithSeekMethod) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_false_trait(t: &mut StructWithSeekTrait) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_false_trait_owned<T>(mut t: StructWithSeekTrait) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_false_trait_bound<T: MySeekTrait>(t: &mut T) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should trigger clippy warning
+fn seek_to_start<T: Seek>(t: &mut T) {
+ t.rewind();
+}
+
+// This should trigger clippy warning
+fn owned_seek_to_start<T: Seek>(mut t: T) {
+ t.rewind();
+}
+
+// This should NOT trigger clippy warning because
+// it does not seek to start
+fn seek_to_5<T: Seek>(t: &mut T) {
+ t.seek(SeekFrom::Start(5));
+}
+
+// This should NOT trigger clippy warning because
+// it does not seek to start
+fn seek_to_end<T: Seek>(t: &mut T) {
+ t.seek(SeekFrom::End(0));
+}
+
+fn main() {
+ let mut f = OpenOptions::new()
+ .write(true)
+ .read(true)
+ .create(true)
+ .open("foo.txt")
+ .unwrap();
+
+ let mut my_struct_trait = StructWithSeekTrait {};
+ seek_to_start_false_trait_bound(&mut my_struct_trait);
+
+ let hello = "Hello!\n";
+ write!(f, "{hello}").unwrap();
+ seek_to_5(&mut f);
+ seek_to_end(&mut f);
+ seek_to_start(&mut f);
+
+ let mut buf = String::new();
+ f.read_to_string(&mut buf).unwrap();
+
+ assert_eq!(&buf, hello);
+}
+
+fn msrv_1_54() {
+ #![clippy::msrv = "1.54"]
+
+ let mut f = OpenOptions::new()
+ .write(true)
+ .read(true)
+ .create(true)
+ .open("foo.txt")
+ .unwrap();
+
+ let hello = "Hello!\n";
+ write!(f, "{hello}").unwrap();
+
+ f.seek(SeekFrom::Start(0));
+
+ let mut buf = String::new();
+ f.read_to_string(&mut buf).unwrap();
+
+ assert_eq!(&buf, hello);
+}
+
+fn msrv_1_55() {
+ #![clippy::msrv = "1.55"]
+
+ let mut f = OpenOptions::new()
+ .write(true)
+ .read(true)
+ .create(true)
+ .open("foo.txt")
+ .unwrap();
+
+ let hello = "Hello!\n";
+ write!(f, "{hello}").unwrap();
+
+ f.rewind();
+
+ let mut buf = String::new();
+ f.read_to_string(&mut buf).unwrap();
+
+ assert_eq!(&buf, hello);
+}
--- /dev/null
+// run-rustfix
+#![allow(unused)]
+#![feature(custom_inner_attributes)]
+#![warn(clippy::seek_to_start_instead_of_rewind)]
+
+use std::fs::OpenOptions;
+use std::io::{Read, Seek, SeekFrom, Write};
+
+struct StructWithSeekMethod {}
+
+impl StructWithSeekMethod {
+ fn seek(&mut self, from: SeekFrom) {}
+}
+
+trait MySeekTrait {
+ fn seek(&mut self, from: SeekFrom) {}
+}
+
+struct StructWithSeekTrait {}
+impl MySeekTrait for StructWithSeekTrait {}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_false_method(t: &mut StructWithSeekMethod) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_method_owned_false<T>(mut t: StructWithSeekMethod) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_false_trait(t: &mut StructWithSeekTrait) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_false_trait_owned<T>(mut t: StructWithSeekTrait) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should NOT trigger clippy warning because
+// StructWithSeekMethod does not implement std::io::Seek;
+fn seek_to_start_false_trait_bound<T: MySeekTrait>(t: &mut T) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should trigger clippy warning
+fn seek_to_start<T: Seek>(t: &mut T) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should trigger clippy warning
+fn owned_seek_to_start<T: Seek>(mut t: T) {
+ t.seek(SeekFrom::Start(0));
+}
+
+// This should NOT trigger clippy warning because
+// it does not seek to start
+fn seek_to_5<T: Seek>(t: &mut T) {
+ t.seek(SeekFrom::Start(5));
+}
+
+// This should NOT trigger clippy warning because
+// it does not seek to start
+fn seek_to_end<T: Seek>(t: &mut T) {
+ t.seek(SeekFrom::End(0));
+}
+
+fn main() {
+ let mut f = OpenOptions::new()
+ .write(true)
+ .read(true)
+ .create(true)
+ .open("foo.txt")
+ .unwrap();
+
+ let mut my_struct_trait = StructWithSeekTrait {};
+ seek_to_start_false_trait_bound(&mut my_struct_trait);
+
+ let hello = "Hello!\n";
+ write!(f, "{hello}").unwrap();
+ seek_to_5(&mut f);
+ seek_to_end(&mut f);
+ seek_to_start(&mut f);
+
+ let mut buf = String::new();
+ f.read_to_string(&mut buf).unwrap();
+
+ assert_eq!(&buf, hello);
+}
+
+fn msrv_1_54() {
+ #![clippy::msrv = "1.54"]
+
+ let mut f = OpenOptions::new()
+ .write(true)
+ .read(true)
+ .create(true)
+ .open("foo.txt")
+ .unwrap();
+
+ let hello = "Hello!\n";
+ write!(f, "{hello}").unwrap();
+
+ f.seek(SeekFrom::Start(0));
+
+ let mut buf = String::new();
+ f.read_to_string(&mut buf).unwrap();
+
+ assert_eq!(&buf, hello);
+}
+
+fn msrv_1_55() {
+ #![clippy::msrv = "1.55"]
+
+ let mut f = OpenOptions::new()
+ .write(true)
+ .read(true)
+ .create(true)
+ .open("foo.txt")
+ .unwrap();
+
+ let hello = "Hello!\n";
+ write!(f, "{hello}").unwrap();
+
+ f.seek(SeekFrom::Start(0));
+
+ let mut buf = String::new();
+ f.read_to_string(&mut buf).unwrap();
+
+ assert_eq!(&buf, hello);
+}
--- /dev/null
+error: used `seek` to go to the start of the stream
+ --> $DIR/seek_to_start_instead_of_rewind.rs:54:7
+ |
+LL | t.seek(SeekFrom::Start(0));
+ | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `rewind()`
+ |
+ = note: `-D clippy::seek-to-start-instead-of-rewind` implied by `-D warnings`
+
+error: used `seek` to go to the start of the stream
+ --> $DIR/seek_to_start_instead_of_rewind.rs:59:7
+ |
+LL | t.seek(SeekFrom::Start(0));
+ | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `rewind()`
+
+error: used `seek` to go to the start of the stream
+ --> $DIR/seek_to_start_instead_of_rewind.rs:131:7
+ |
+LL | f.seek(SeekFrom::Start(0));
+ | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `rewind()`
+
+error: aborting due to 3 previous errors
+
projects / rust.git / commitdiff