]> git.lizzy.rs Git - rust.git/commitdiff
assign the correct `DefId` in `nominal_obligations`
authorBastian Kauschke <bastian_kauschke@hotmail.de>
Tue, 22 Sep 2020 09:36:54 +0000 (11:36 +0200)
committerBastian Kauschke <bastian_kauschke@hotmail.de>
Thu, 24 Sep 2020 07:04:23 +0000 (09:04 +0200)
compiler/rustc_trait_selection/src/traits/wf.rs
src/test/ui/const-generics/const_evaluatable_checked/cross_crate_predicate.stderr
src/test/ui/const-generics/const_evaluatable_checked/let-bindings.stderr

index 998990f374cb96ea1e2af6cf77a957eeeb35707c..909cd2aa1551ec3bd93f7393a4da20c961334ffb 100644 (file)
@@ -7,8 +7,9 @@
 use rustc_middle::ty::subst::{GenericArg, GenericArgKind, SubstsRef};
 use rustc_middle::ty::{self, ToPredicate, Ty, TyCtxt, TypeFoldable, WithConstness};
 use rustc_span::Span;
-use std::rc::Rc;
 
+use std::iter;
+use std::rc::Rc;
 /// Returns the set of obligations needed to make `arg` well-formed.
 /// If `arg` contains unresolved inference variables, this may include
 /// further WF obligations. However, if `arg` IS an unresolved
@@ -616,13 +617,24 @@ fn nominal_obligations(
         def_id: DefId,
         substs: SubstsRef<'tcx>,
     ) -> Vec<traits::PredicateObligation<'tcx>> {
-        let predicates = self.infcx.tcx.predicates_of(def_id).instantiate(self.infcx.tcx, substs);
+        let predicates = self.infcx.tcx.predicates_of(def_id);
+        let mut origins = vec![def_id; predicates.predicates.len()];
+        let mut head = predicates;
+        while let Some(parent) = head.parent {
+            head = self.infcx.tcx.predicates_of(parent);
+            origins.extend(iter::repeat(parent).take(head.predicates.len()));
+        }
+
+        let predicates = predicates.instantiate(self.infcx.tcx, substs);
+        debug_assert_eq!(predicates.predicates.len(), origins.len());
+
         predicates
             .predicates
             .into_iter()
             .zip(predicates.spans.into_iter())
-            .map(|(pred, span)| {
-                let cause = self.cause(traits::BindingObligation(def_id, span));
+            .zip(origins.into_iter().rev())
+            .map(|((pred, span), origin_def_id)| {
+                let cause = self.cause(traits::BindingObligation(origin_def_id, span));
                 traits::Obligation::new(cause, self.param_env, pred)
             })
             .filter(|pred| !pred.has_escaping_bound_vars())
index e7da191e670ec5646c56ccb1bd8b8268ef5df490..4af68118be31fda7ff6c53d2ec9a430ae8417982 100644 (file)
@@ -33,7 +33,7 @@ LL |     let _ = const_evaluatable_lib::test1::<T>();
   ::: $DIR/auxiliary/const_evaluatable_lib.rs:6:10
    |
 LL |     [u8; std::mem::size_of::<T>() - 1]: Sized,
-   |          ---------------------------- required by this bound in `test1::{{constant}}#1`
+   |          ---------------------------- required by this bound in `test1`
    |
    = note: this may fail depending on what value the parameter takes
 
@@ -46,7 +46,7 @@ LL |     let _ = const_evaluatable_lib::test1::<T>();
   ::: $DIR/auxiliary/const_evaluatable_lib.rs:4:27
    |
 LL | pub fn test1<T>() -> [u8; std::mem::size_of::<T>() - 1]
-   |                           ---------------------------- required by this bound in `test1::{{constant}}#1`
+   |                           ---------------------------- required by this bound in `test1`
    |
    = note: this may fail depending on what value the parameter takes
 
index b76e300663d762e5f715bf90ce5203b63b06f138..dd27b81ee03423f60148001998f0b577acecd0ff 100644 (file)
@@ -2,7 +2,7 @@ error: constant expression depends on a generic parameter
   --> $DIR/let-bindings.rs:6:68
    |
 LL | fn test<const N: usize>() -> [u8; { let x = N; N + 1 }] where [u8; { let x = N; N + 1 }]: Default {
-   |                                                                    ^^^^^^^^^^^^^^^^^^^^ required by this bound in `test::{{constant}}#0`
+   |                                                                    ^^^^^^^^^^^^^^^^^^^^ required by this bound in `test`
    |
    = help: consider moving this anonymous constant into a `const` function