]> git.lizzy.rs Git - rust.git/commitdiff
Lower return type outside async block creation
authorArpad Borsos <swatinem@swatinem.de>
Sat, 19 Nov 2022 17:23:32 +0000 (18:23 +0100)
committerArpad Borsos <swatinem@swatinem.de>
Sat, 19 Nov 2022 17:23:32 +0000 (18:23 +0100)
This allows feeding a different output type to async blocks with a
different `ImplTraitContext`.

compiler/rustc_ast_lowering/src/expr.rs

index eaa5a38388afcc214214b4b4414ef1327c8dcaeb..7cb794c2b09ec6e131d0e2233e060e3e7735299f 100644 (file)
@@ -588,17 +588,12 @@ pub(super) fn make_async_expr(
         &mut self,
         capture_clause: CaptureBy,
         closure_node_id: NodeId,
-        ret_ty: Option<AstP<Ty>>,
+        ret_ty: Option<hir::FnRetTy<'hir>>,
         span: Span,
         async_gen_kind: hir::AsyncGeneratorKind,
         body: impl FnOnce(&mut Self) -> hir::Expr<'hir>,
     ) -> hir::ExprKind<'hir> {
-        let output = match ret_ty {
-            Some(ty) => hir::FnRetTy::Return(
-                self.lower_ty(&ty, &ImplTraitContext::Disallowed(ImplTraitPosition::AsyncBlock)),
-            ),
-            None => hir::FnRetTy::DefaultReturn(self.lower_span(span)),
-        };
+        let output = ret_ty.unwrap_or_else(|| hir::FnRetTy::DefaultReturn(self.lower_span(span)));
 
         // Resume argument type. We let the compiler infer this to simplify the lowering. It is
         // fully constrained by `future::from_generator`.
@@ -1003,8 +998,13 @@ fn lower_expr_async_closure(
             // Transform `async |x: u8| -> X { ... }` into
             // `|x: u8| future_from_generator(|| -> X { ... })`.
             let body_id = this.lower_fn_body(&outer_decl, |this| {
-                let async_ret_ty =
-                    if let FnRetTy::Ty(ty) = &decl.output { Some(ty.clone()) } else { None };
+                let async_ret_ty = if let FnRetTy::Ty(ty) = &decl.output {
+                    let itctx = ImplTraitContext::Disallowed(ImplTraitPosition::AsyncBlock);
+                    Some(hir::FnRetTy::Return(this.lower_ty(&ty, &itctx)))
+                } else {
+                    None
+                };
+
                 let async_body = this.make_async_expr(
                     capture_clause,
                     inner_closure_id,