]> git.lizzy.rs Git - rust.git/commitdiff
Fix ICE on certain sequence repetitions.
authorJeffrey Seyfried <jeffrey.seyfried@gmail.com>
Fri, 10 Feb 2017 23:23:11 +0000 (23:23 +0000)
committerJeffrey Seyfried <jeffrey.seyfried@gmail.com>
Fri, 10 Feb 2017 23:58:18 +0000 (23:58 +0000)
src/libsyntax/parse/parser.rs
src/test/compile-fail/issue-39709.rs [new file with mode: 0644]

index b051928ff9d3c69abad69a90b18bdb231ab01984..2c4fa8e15edf2bbf54ee91868e8d4368f4d627dd 100644 (file)
@@ -302,11 +302,20 @@ fn next_tok(&mut self) -> TokenAndSpan {
                 if i + 1 < tts.len() {
                     self.tts.push((tts, i + 1));
                 }
-                if let TokenTree::Token(sp, tok) = tt {
-                    TokenAndSpan { tok: tok, sp: sp }
-                } else {
-                    self.tts.push((tt, 0));
-                    continue
+                // FIXME(jseyfried): remove after fixing #39390 in #39419.
+                if self.quote_depth > 0 {
+                    if let TokenTree::Sequence(sp, _) = tt {
+                        self.span_err(sp, "attempted to repeat an expression containing no \
+                                           syntax variables matched as repeating at this depth");
+                    }
+                }
+                match tt {
+                    TokenTree::Token(sp, tok) => TokenAndSpan { tok: tok, sp: sp },
+                    _ if tt.len() > 0 => {
+                        self.tts.push((tt, 0));
+                        continue
+                    }
+                    _ => continue,
                 }
             } else {
                 TokenAndSpan { tok: token::Eof, sp: self.span }
diff --git a/src/test/compile-fail/issue-39709.rs b/src/test/compile-fail/issue-39709.rs
new file mode 100644 (file)
index 0000000..0f66fe8
--- /dev/null
@@ -0,0 +1,15 @@
+// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+fn main() {
+    println!("{}", { macro_rules! x { ($()*) => {} } 33 });
+    //~^ ERROR no syntax variables matched as repeating at this depth
+}
+