]> git.lizzy.rs Git - rust.git/commitdiff
internal: document review requesting etiquette
authorAleksey Kladov <aleksey.kladov@gmail.com>
Tue, 13 Apr 2021 11:13:50 +0000 (14:13 +0300)
committerAleksey Kladov <aleksey.kladov@gmail.com>
Mon, 19 Apr 2021 13:08:49 +0000 (16:08 +0300)
* don't feel obliged to quickly review every PR assigned to you
* so that other folks can notify you about interesting PRs without
  thinking to much about creating additional work for you

docs/dev/README.md

index d0e6d29d8fa412ff668927ff04cf7469935e6a9a..360cedf883e5066a71345959da887a43349b10e3 100644 (file)
@@ -242,6 +242,9 @@ There are three sets of people with extra permissions:
   They also have direct commit access, but all changes should via bors queue.
   It's ok to self-approve if you think you know what you are doing!
   bors should automatically sync the permissions.
+  Feel free to assign any PR to a reviewer with the relevant expertise to bring the work to their attention.
+  Don't feel pressured to review assigned PRs though.
+  If you don't feel like reviewing for whatever reason, someone else will pick the review up!
 * [**triage**](https://github.com/orgs/rust-analyzer/teams/triage) team in the organization.
   This team can label and close issues.