Auto merge of #51639 - SimonSapin:missing-alloc, r=rkruppe

Update the error message for a missing global allocator

Don’t mention `#[default_lib_allocator]` (which is an implementation detail irrelevant to most users) and  instead suggest using `#[global_allocator]`, which is often the correct fix.

diff --git a/src/librustc_metadata/creader.rs b/src/librustc_metadata/creader.rs
index e41b3f5f53b252fee2d1829136d077bd8a0bcdd8..6c1991457433f6231b445ea18632501afff5bdc7 100644 (file)
--- a/src/librustc_metadata/creader.rs
+++ b/src/librustc_metadata/creader.rs
@@ -986,8 +986,10 @@ fn inject_allocator_crate(&mut self, krate: &ast::Crate) {
             },
             None => {
                 if !attr::contains_name(&krate.attrs, "default_lib_allocator") {
-                    self.sess.err("no #[default_lib_allocator] found but one is \
-                                   required; is libstd not linked?");
+                    self.sess.err("no global memory allocator found but one is \
+                                   required; link to std or \
+                                   add #[global_allocator] to a static item \
+                                   that implements the GlobalAlloc trait.");
                     return;
                 }
                 self.sess.allocator_kind.set(Some(AllocatorKind::DefaultLib));

diff --git a/src/test/ui/missing-allocator.rs b/src/test/ui/missing-allocator.rs
new file mode 100644 (file)
index 0000000..2428263
--- /dev/null
+++ b/src/test/ui/missing-allocator.rs
@@ -0,0 +1,26 @@
+// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-flags: -C panic=abort
+// no-prefer-dynamic
+
+#![no_std]
+#![crate_type = "staticlib"]
+#![feature(panic_implementation, lang_items, alloc)]
+
+#[panic_implementation]
+fn panic(_: &core::panic::PanicInfo) -> ! {
+    loop {}
+}
+
+#[lang = "oom"]
+fn oom() {}
+
+extern crate alloc;

diff --git a/src/test/ui/missing-allocator.stderr b/src/test/ui/missing-allocator.stderr
new file mode 100644 (file)
index 0000000..11e0085
--- /dev/null
+++ b/src/test/ui/missing-allocator.stderr
@@ -0,0 +1,4 @@
+error: no global memory allocator found but one is required; link to std or add #[global_allocator] to a static item that implements the GlobalAlloc trait.
+
+error: aborting due to previous error
+