Simplify checking for all ones in int

diff --git a/clippy_lints/src/identity_op.rs b/clippy_lints/src/identity_op.rs
index 21aa914155e05a655f01a539657f31f70c7d47db..85dfb6b4ad092e578c582e30a2fb03e6f9b40ed5 100644 (file)
--- a/clippy_lints/src/identity_op.rs
+++ b/clippy_lints/src/identity_op.rs
@@ -58,18 +58,18 @@ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
     }
 }
 
-fn no_zeros(v: &ConstInt) -> bool {
+fn all_ones(v: &ConstInt) -> bool {
     match *v {
-        ConstInt::I8(i) => i.count_zeros() == 0,
-        ConstInt::I16(i) => i.count_zeros() == 0,
-        ConstInt::I32(i) => i.count_zeros() == 0,
-        ConstInt::I64(i) => i.count_zeros() == 0,
-        ConstInt::I128(i) => i.count_zeros() == 0,
-        ConstInt::U8(i) => i.count_zeros() == 0,
-        ConstInt::U16(i) => i.count_zeros() == 0,
-        ConstInt::U32(i) => i.count_zeros() == 0,
-        ConstInt::U64(i) => i.count_zeros() == 0,
-        ConstInt::U128(i) => i.count_zeros() == 0,
+        ConstInt::I8(i) => i == !0,
+        ConstInt::I16(i) => i == !0,
+        ConstInt::I32(i) => i == !0,
+        ConstInt::I64(i) => i == !0,
+        ConstInt::I128(i) => i == !0,
+        ConstInt::U8(i) => i == !0,
+        ConstInt::U16(i) => i == !0,
+        ConstInt::U32(i) => i == !0,
+        ConstInt::U64(i) => i == !0,
+        ConstInt::U128(i) => i == !0,
         _ => false
     }
 }
@@ -79,7 +79,7 @@ fn check(cx: &LateContext, e: &Expr, m: i8, span: Span, arg: Span) {
     if let Some(Constant::Int(v)) = constant_simple(cx, e) {
         if match m {
             0 => v.to_u128_unchecked() == 0,
-            -1 => no_zeros(&v),
+            -1 => all_ones(&v),
             1 => v.to_u128_unchecked() == 1,
             _ => unreachable!(),
         } {