Improve performance of drawing - no need to start drawing again

diff --git a/java/com/irtimaled/bbor/ClientProxy.java b/java/com/irtimaled/bbor/ClientProxy.java
index 05219e506d3b988071dd82805188e2206f6ca748..e920affe5862a96337aac674e7d4c20594014a61 100644 (file)
--- a/java/com/irtimaled/bbor/ClientProxy.java
+++ b/java/com/irtimaled/bbor/ClientProxy.java
@@ -383,7 +383,6 @@ public class ClientProxy extends CommonProxy {
         for (BlockPos door : villageBB.getDoors()) {
             OffsetPoint point = new OffsetPoint(door);
 
-
             worldRenderer.addVertex(point.getX(), point.getY(), point.getZ());
             worldRenderer.addVertex(center.getX(), center.getY(), center.getZ());
         }
@@ -426,50 +425,34 @@ public class ClientProxy extends CommonProxy {
         worldRenderer.addVertex(bb.maxX, bb.minY, bb.minZ);
         worldRenderer.addVertex(bb.maxX, bb.minY, bb.maxZ);
         worldRenderer.addVertex(bb.minX, bb.minY, bb.maxZ);
-        tessellator.draw();
 
-        if (bb.minY == bb.maxY) {
-            return;
-        }
+        if (bb.minY != bb.maxY) {
 
-        worldRenderer.startDrawing(GL11.GL_QUADS);
-        worldRenderer.setColorRGBA(colorR, colorG, colorB, alphaChannel);
-        worldRenderer.addVertex(bb.minX, bb.maxY, bb.minZ);
-        worldRenderer.addVertex(bb.maxX, bb.maxY, bb.minZ);
-        worldRenderer.addVertex(bb.maxX, bb.maxY, bb.maxZ);
-        worldRenderer.addVertex(bb.minX, bb.maxY, bb.maxZ);
-        tessellator.draw();
+            worldRenderer.addVertex(bb.minX, bb.maxY, bb.minZ);
+            worldRenderer.addVertex(bb.maxX, bb.maxY, bb.minZ);
+            worldRenderer.addVertex(bb.maxX, bb.maxY, bb.maxZ);
+            worldRenderer.addVertex(bb.minX, bb.maxY, bb.maxZ);
 
-        worldRenderer.startDrawing(GL11.GL_QUADS);
-        worldRenderer.setColorRGBA(colorR, colorG, colorB, alphaChannel);
-        worldRenderer.addVertex(bb.minX, bb.minY, bb.maxZ);
-        worldRenderer.addVertex(bb.minX, bb.maxY, bb.maxZ);
-        worldRenderer.addVertex(bb.maxX, bb.maxY, bb.maxZ);
-        worldRenderer.addVertex(bb.maxX, bb.minY, bb.maxZ);
-        tessellator.draw();
+            worldRenderer.addVertex(bb.minX, bb.minY, bb.maxZ);
+            worldRenderer.addVertex(bb.minX, bb.maxY, bb.maxZ);
+            worldRenderer.addVertex(bb.maxX, bb.maxY, bb.maxZ);
+            worldRenderer.addVertex(bb.maxX, bb.minY, bb.maxZ);
 
-        worldRenderer.startDrawing(GL11.GL_QUADS);
-        worldRenderer.setColorRGBA(colorR, colorG, colorB, alphaChannel);
-        worldRenderer.addVertex(bb.minX, bb.minY, bb.minZ);
-        worldRenderer.addVertex(bb.minX, bb.maxY, bb.minZ);
-        worldRenderer.addVertex(bb.maxX, bb.maxY, bb.minZ);
-        worldRenderer.addVertex(bb.maxX, bb.minY, bb.minZ);
-        tessellator.draw();
+            worldRenderer.addVertex(bb.minX, bb.minY, bb.minZ);
+            worldRenderer.addVertex(bb.minX, bb.maxY, bb.minZ);
+            worldRenderer.addVertex(bb.maxX, bb.maxY, bb.minZ);
+            worldRenderer.addVertex(bb.maxX, bb.minY, bb.minZ);
 
-        worldRenderer.startDrawing(GL11.GL_QUADS);
-        worldRenderer.setColorRGBA(colorR, colorG, colorB, alphaChannel);
-        worldRenderer.addVertex(bb.minX, bb.minY, bb.minZ);
-        worldRenderer.addVertex(bb.minX, bb.minY, bb.maxZ);
-        worldRenderer.addVertex(bb.minX, bb.maxY, bb.maxZ);
-        worldRenderer.addVertex(bb.minX, bb.maxY, bb.minZ);
-        tessellator.draw();
+            worldRenderer.addVertex(bb.minX, bb.minY, bb.minZ);
+            worldRenderer.addVertex(bb.minX, bb.minY, bb.maxZ);
+            worldRenderer.addVertex(bb.minX, bb.maxY, bb.maxZ);
+            worldRenderer.addVertex(bb.minX, bb.maxY, bb.minZ);
 
-        worldRenderer.startDrawing(GL11.GL_QUADS);
-        worldRenderer.setColorRGBA(colorR, colorG, colorB, alphaChannel);
-        worldRenderer.addVertex(bb.maxX, bb.minY, bb.minZ);
-        worldRenderer.addVertex(bb.maxX, bb.minY, bb.maxZ);
-        worldRenderer.addVertex(bb.maxX, bb.maxY, bb.maxZ);
-        worldRenderer.addVertex(bb.maxX, bb.maxY, bb.minZ);
+            worldRenderer.addVertex(bb.maxX, bb.minY, bb.minZ);
+            worldRenderer.addVertex(bb.maxX, bb.minY, bb.maxZ);
+            worldRenderer.addVertex(bb.maxX, bb.maxY, bb.maxZ);
+            worldRenderer.addVertex(bb.maxX, bb.maxY, bb.minZ);
+        }
         tessellator.draw();
     }