]> git.lizzy.rs Git - rust.git/commitdiff
attr: fix expected meta-item for `#[stable]`
authorDavid Wood <david.wood@huawei.com>
Wed, 13 Jul 2022 09:36:12 +0000 (10:36 +0100)
committerDavid Wood <david.wood@huawei.com>
Wed, 20 Jul 2022 10:29:56 +0000 (11:29 +0100)
When an unexpected meta item is provided to `#[stable]`, the diagnostic
lists "since" and "note" as expected meta-items, however the surrounding
code actually expects "feature" and "since".

Signed-off-by: David Wood <david.wood@huawei.com>
compiler/rustc_attr/src/builtin.rs
src/test/ui/stability-attribute/stability-attribute-sanity-2.stderr
src/test/ui/stability-attribute/stability-attribute-sanity.stderr

index f344bdba5dbfa4dae817dc76662dae0123ef78ff..16e56c6d8511ac2a52f1e0a57568b0510e99dd63 100644 (file)
@@ -404,7 +404,7 @@ fn find_stability_generic<'a, I>(
                                         meta.span(),
                                         AttrError::UnknownMetaItem(
                                             pprust::path_to_string(&mi.path),
-                                            &["since", "note"],
+                                            &["feature", "since"],
                                         ),
                                     );
                                     continue 'outer;
index bd7b88da1584da0a2841b769d33e8d478bb57415..8dbcc6c97efd5fea50b7fe63657218a5f00c07c2 100644 (file)
@@ -8,7 +8,7 @@ error[E0541]: unknown meta item 'sinse'
   --> $DIR/stability-attribute-sanity-2.rs:10:25
    |
 LL | #[stable(feature = "a", sinse = "1.0.0")]
-   |                         ^^^^^^^^^^^^^^^ expected one of `since`, `note`
+   |                         ^^^^^^^^^^^^^^^ expected one of `feature`, `since`
 
 error[E0545]: `issue` must be a non-zero numeric string or "none"
   --> $DIR/stability-attribute-sanity-2.rs:13:27
index fcb1eefddbcef733b7777a3273d27a903b1a8c50..079230b2a3160e5462cb70d72b0655235be734a2 100644 (file)
@@ -14,7 +14,7 @@ error[E0541]: unknown meta item 'reason'
   --> $DIR/stability-attribute-sanity.rs:8:42
    |
 LL |     #[stable(feature = "a", since = "b", reason)]
-   |                                          ^^^^^^ expected one of `since`, `note`
+   |                                          ^^^^^^ expected one of `feature`, `since`
 
 error[E0539]: incorrect meta item
   --> $DIR/stability-attribute-sanity.rs:11:29