]> git.lizzy.rs Git - rust.git/commitdiff
convert TODOs to FIXMEs
authorNiko Matsakis <niko@alum.mit.edu>
Tue, 1 Sep 2015 20:55:40 +0000 (16:55 -0400)
committerNiko Matsakis <niko@alum.mit.edu>
Sun, 6 Sep 2015 11:27:23 +0000 (07:27 -0400)
src/librustc_mir/build/expr/category.rs
src/librustc_mir/tcx/mod.rs

index 8bfd0a1c7d2c334fe4612dccdf158483a8e32480..1f9928acdc81bf8c1216e1a27ee7f3c6b7dbf2af 100644 (file)
@@ -87,7 +87,9 @@ pub fn of<H:Hair>(ek: &ExprKind<H>) -> Option<Category> {
             ExprKind::Break { .. } |
             ExprKind::Continue { .. } |
             ExprKind::Return { .. } =>
-                Some(Category::Rvalue(RvalueFunc::Into)), // TODO
+                // FIXME(#27840) these probably want their own
+                // category, like "nonterminating"
+                Some(Category::Rvalue(RvalueFunc::Into)),
         }
     }
 }
index 35cfc7729987d22f7c4f7b1b37b2d09d82150286..2e9eae0956d9693700a6245cb5913aff269dbb51 100644 (file)
@@ -106,7 +106,7 @@ fn fields(&mut self, adt_def: ty::AdtDef<'tcx>, variant_index: usize) -> Vec<Fie
 
     fn needs_drop(&mut self, ty: Ty<'tcx>, span: Self::Span) -> bool {
         if self.infcx.type_moves_by_default(ty, span) {
-            // TODO we should do an add'l check here to determine if
+            // FIXME(#21859) we should do an add'l check here to determine if
             // any dtor will execute, but the relevant fn
             // (`type_needs_drop`) is currently factored into
             // `librustc_trans`, so we can't easily do so.