Address review feedback

diff --git a/src/librustc/driver/config.rs b/src/librustc/driver/config.rs
index 890093a10ecc75d4f1f7b7baecd86bddfdddc6b9..2d200c82a94a280f98c218b2e1de75df068cd61a 100644 (file)
--- a/src/librustc/driver/config.rs
+++ b/src/librustc/driver/config.rs
@@ -97,6 +97,9 @@ pub struct Options {
     pub color: ColorConfig,
     pub externs: HashMap<String, Vec<String>>,
     pub crate_name: Option<String>,
+    /// An optional name to use as the crate for std during std injection,
+    /// written `extern crate std = "name"`. Default to "std". Used by
+    /// out-of-tree drivers.
     pub alt_std_name: Option<String>
 }
 
@@ -793,10 +796,10 @@ pub fn build_session_options(matches: &getopts::Matches) -> Options {
     }
 }
 
-pub fn parse_crate_types_from_list(crate_types_list_list: Vec<String>) -> Result<Vec<CrateType>, String> {
+pub fn parse_crate_types_from_list(list_list: Vec<String>) -> Result<Vec<CrateType>, String> {
 
     let mut crate_types: Vec<CrateType> = Vec::new();
-    for unparsed_crate_type in crate_types_list_list.iter() {
+    for unparsed_crate_type in list_list.iter() {
         for part in unparsed_crate_type.as_slice().split(',') {
             let new_part = match part {
                 "lib"       => default_lib_output(),

diff --git a/src/librustc/driver/driver.rs b/src/librustc/driver/driver.rs
index 311d9fb93a1211e231b2cd294bb4920034be31ef..9796aab51fb6b26b125bdc3fdd3524eabe31b2ed 100644 (file)
--- a/src/librustc/driver/driver.rs
+++ b/src/librustc/driver/driver.rs
@@ -181,6 +181,7 @@ pub fn phase_1_parse_input(sess: &Session, cfg: ast::CrateConfig, input: &Input)
 // modified
 
 /// Run the "early phases" of the compiler: initial `cfg` processing,
+/// loading compiler plugins (including those from `addl_plugins`),
 /// syntax expansion, secondary `cfg` expansion, synthesis of a test
 /// harness if one is to be provided and injection of a dependency on the
 /// standard library and prelude.