]> git.lizzy.rs Git - rust.git/commitdiff
lint-docs: Warn on missing lint when documenting.
authorEric Huss <eric@huss.org>
Sat, 26 Dec 2020 21:48:09 +0000 (13:48 -0800)
committerEric Huss <eric@huss.org>
Sat, 26 Dec 2020 21:48:09 +0000 (13:48 -0800)
src/tools/lint-docs/src/groups.rs

index 0a69b18a3325413a4aa4b8642ca2e37152f3edb9..e8fd19a63812b4d03f8350d8f77388c1e5251cbe 100644 (file)
@@ -116,13 +116,23 @@ fn make_groups_table(
         result.push('\n');
         result.push_str("[warn-by-default]: listing/warn-by-default.md\n");
         for lint_name in to_link {
-            let lint_def =
-                lints.iter().find(|l| l.name == lint_name.replace("-", "_")).ok_or_else(|| {
-                    format!(
-                        "`rustc -W help` defined lint `{}` but that lint does not appear to exist",
+            let lint_def = match lints.iter().find(|l| l.name == lint_name.replace("-", "_")) {
+                Some(def) => def,
+                None => {
+                    let msg = format!(
+                        "`rustc -W help` defined lint `{}` but that lint does not \
+                        appear to exist\n\
+                        Check that the lint definition includes the appropriate doc comments.",
                         lint_name
-                    )
-                })?;
+                    );
+                    if self.validate {
+                        return Err(msg.into());
+                    } else {
+                        eprintln!("warning: {}", msg);
+                        continue;
+                    }
+                }
+            };
             write!(
                 result,
                 "[{}]: listing/{}#{}\n",