--- /dev/null
+// run-pass
+// revisions: mir thir
+// [thir]compile-flags: -Z thir-unsafeck
+
+#![feature(untagged_unions)]
+
+union Foo {
+ bar: i8,
+ _blah: isize,
+ _zst: (),
+}
+
+struct FooHolder {
+ inner_foo: Foo
+}
+
+fn do_nothing(_x: &mut Foo) {}
+
+pub fn main() {
+ let mut foo = Foo { bar: 5 };
+ do_nothing(&mut foo);
+ foo.bar = 6;
+ unsafe { foo.bar += 1; }
+ assert_eq!(unsafe { foo.bar }, 7);
+ unsafe {
+ let Foo { bar: inner } = foo;
+ assert_eq!(inner, 7);
+ }
+
+ let foo = Foo { bar: 5 };
+ let foo = if let 3 = if let true = true { 3 } else { 4 } { foo } else { foo };
+
+ let (_foo2, _random) = (foo, 42);
+
+ let mut foo_holder = FooHolder { inner_foo: Foo { bar: 5 } };
+ foo_holder.inner_foo.bar = 4;
+ assert_eq!(unsafe { foo_holder.inner_foo.bar }, 4);
+ drop(foo_holder);
+}
-warning: unnecessary `unsafe` block
- --> $DIR/union.rs:61:5
+error[E0133]: access to union field is unsafe and requires unsafe function or block
+ --> $DIR/union.rs:30:20
|
-LL | unsafe {
- | ^^^^^^ unnecessary `unsafe` block
+LL | Foo { bar: _a } => {},
+ | ^^ access to union field
|
- = note: `#[warn(unused_unsafe)]` on by default
+ = note: the field may not be properly initialized: using uninitialized data will cause undefined behavior
-warning: unnecessary `unsafe` block
- --> $DIR/union.rs:66:5
+error[E0133]: access to union field is unsafe and requires unsafe function or block
+ --> $DIR/union.rs:32:11
|
-LL | unsafe {
- | ^^^^^^ unnecessary `unsafe` block
+LL | match foo {
+ | ^^^ access to union field
+ |
+ = note: the field may not be properly initialized: using uninitialized data will cause undefined behavior
-warning: 2 warnings emitted
+error: aborting due to 2 previous errors
+For more information about this error, try `rustc --explain E0133`.
-// run-pass
// revisions: mir thir
// [thir]compile-flags: -Z thir-unsafeck
Pineapple,
}
-struct FooHolder {
- inner_foo: Foo
-}
-
fn do_nothing(_x: &mut Foo) {}
pub fn main() {
let mut foo = Foo { bar: 5 };
do_nothing(&mut foo);
- foo.bar = 6;
- unsafe { foo.bar += 1; }
- assert_eq!(unsafe { foo.bar }, 7);
- unsafe {
- let Foo { bar: inner } = foo;
- assert_eq!(inner, 7);
+
+ // This is UB, so this test isn't run
+ match foo {
+ Foo { bar: _a } => {}, //~ ERROR access to union field is unsafe
+ }
+ match foo { //[mir]~ ERROR access to union field is unsafe
+ Foo {
+ pizza: Pizza { //[thir]~ ERROR access to union field is unsafe
+ topping: Some(PizzaTopping::Cheese) | Some(PizzaTopping::Pineapple) | None
+ }
+ } => {},
}
- let foo = if let true = true { foo } else { foo };
- unsafe {
- match foo {
- Foo { bar: _a } => {},
- }
+ // MIR unsafeck incorrectly thinks that no unsafe block is needed to do these
+ match foo {
+ Foo { zst: () } => {}, //[thir]~ ERROR access to union field is unsafe
}
- unsafe {
- match foo {
- Foo {
- pizza: Pizza {
- topping: Some(PizzaTopping::Cheese) | Some(PizzaTopping::Pineapple) | None
- }
- } => {},
- }
+ match foo {
+ Foo { pizza: Pizza { .. } } => {}, //[thir]~ ERROR access to union field is unsafe
}
+
// binding to wildcard is okay
match foo {
Foo { bar: _ } => {},
}
let Foo { bar: _ } = foo;
- // MIR unsafeck incorrectly thinks that it is safe to do these
- unsafe { //[mir]~ WARNING
- match foo {
- Foo { zst: () } => {},
- }
- }
- unsafe { //[mir]~ WARNING
- match foo {
- Foo { pizza: Pizza { .. } } => {},
- }
- }
- let foo = Foo { bar: 5 };
- let foo = if let 3 = if let true = true { 3 } else { 4 } { foo } else { foo };
-
- let (_foo2, _random) = (foo, 42);
-
- let mut foo_holder = FooHolder { inner_foo: Foo { bar: 5 } };
- foo_holder.inner_foo.bar = 4;
- assert_eq!(unsafe { foo_holder.inner_foo.bar }, 4);
- drop(foo_holder);
}
--- /dev/null
+error[E0133]: access to union field is unsafe and requires unsafe function or block
+ --> $DIR/union.rs:30:20
+ |
+LL | Foo { bar: _a } => {},
+ | ^^ access to union field
+ |
+ = note: the field may not be properly initialized: using uninitialized data will cause undefined behavior
+
+error[E0133]: access to union field is unsafe and requires unsafe function or block
+ --> $DIR/union.rs:34:20
+ |
+LL | pizza: Pizza {
+ | ____________________^
+LL | | topping: Some(PizzaTopping::Cheese) | Some(PizzaTopping::Pineapple) | None
+LL | | }
+ | |_____________^ access to union field
+ |
+ = note: the field may not be properly initialized: using uninitialized data will cause undefined behavior
+
+error[E0133]: access to union field is unsafe and requires unsafe function or block
+ --> $DIR/union.rs:42:20
+ |
+LL | Foo { zst: () } => {},
+ | ^^ access to union field
+ |
+ = note: the field may not be properly initialized: using uninitialized data will cause undefined behavior
+
+error[E0133]: access to union field is unsafe and requires unsafe function or block
+ --> $DIR/union.rs:45:22
+ |
+LL | Foo { pizza: Pizza { .. } } => {},
+ | ^^^^^^^^^^^^ access to union field
+ |
+ = note: the field may not be properly initialized: using uninitialized data will cause undefined behavior
+
+error: aborting due to 4 previous errors
+
+For more information about this error, try `rustc --explain E0133`.