]> git.lizzy.rs Git - rust.git/commitdiff
remove resolved TODO questions
authorAnatol Ulrich <anatol.ulrich@ferrous-systems.com>
Wed, 27 Oct 2021 13:40:00 +0000 (15:40 +0200)
committerAnatol Ulrich <anatol.ulrich@ferrous-systems.com>
Wed, 27 Oct 2021 13:40:30 +0000 (15:40 +0200)
crates/ide/src/rename.rs
crates/ide_db/src/source_change.rs

index bb23699cad4df873fde806bc534006a94d73473b..59ba2b867ac662abfcb219007f4fde6b5b5e6cb0 100644 (file)
@@ -168,7 +168,6 @@ fn find_definitions(
     let v: RenameResult<Vec<(ast::NameLike, Definition)>> = symbols.collect();
     match v {
         // remove duplicates
-        // TODO is "unique by `Definition`" correct?
         Ok(v) => {
             if v.is_empty() {
                 Err(format_err!("No references found at position"))
index c80da1d2f791ef325802bc89a292f27b70b4316d..aa910eb3254e4cb9cb3658c2166508c498dc1b80 100644 (file)
@@ -58,7 +58,7 @@ pub fn get_source_edit(&self, file_id: FileId) -> Option<&TextEdit> {
     pub fn merge(mut self, other: SourceChange) -> SourceChange {
         self.extend(other.source_file_edits);
         self.extend(other.file_system_edits);
-        self.is_snippet |= other.is_snippet; // TODO correct?
+        self.is_snippet |= other.is_snippet;
         self
     }
 }