Fix crash when crafting callbacks return strings (#12685)

Co-authored-by: Zughy <4279489-marco_a@users.noreply.gitlab.com>

diff --git a/builtin/game/register.lua b/builtin/game/register.lua
index ee4edabbf73c545e7c069aa89a7456a2942c4670..8b6f5b990648a8ee923541d9618301c0f698e1a9 100644 (file)
--- a/builtin/game/register.lua
+++ b/builtin/game/register.lua
@@ -303,14 +303,16 @@ end
 
 function core.on_craft(itemstack, player, old_craft_list, craft_inv)
        for _, func in ipairs(core.registered_on_crafts) do
-               itemstack = func(itemstack, player, old_craft_list, craft_inv) or itemstack
+               -- cast to ItemStack since func() could return a string
+               itemstack = ItemStack(func(itemstack, player, old_craft_list, craft_inv) or itemstack)
        end
        return itemstack
 end
 
 function core.craft_predict(itemstack, player, old_craft_list, craft_inv)
        for _, func in ipairs(core.registered_craft_predicts) do
-               itemstack = func(itemstack, player, old_craft_list, craft_inv) or itemstack
+               -- cast to ItemStack since func() could return a string
+               itemstack = ItemStack(func(itemstack, player, old_craft_list, craft_inv) or itemstack)
        end
        return itemstack
 end