]> git.lizzy.rs Git - rust.git/commitdiff
try-back-block-type test: Use TryFromSliceError for From test
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Wed, 17 Feb 2021 19:13:51 +0000 (19:13 +0000)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Wed, 17 Feb 2021 19:15:24 +0000 (19:15 +0000)
Using `i32` is rather fragile because it has many implementations -
and indeed I'm about to add one.

TryFromSliceError is nice because it doesn't seem likely to grow new
conversions.  We still have one conversion, from Infallible.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
src/test/ui/try-block/try-block-bad-type.rs
src/test/ui/try-block/try-block-bad-type.stderr

index 496ba145810fbc526e989d9a195abeedf05e3412..ef6e690e1bd0e03edc6ffbeb3bc76af3bc4dd3c7 100644 (file)
@@ -3,7 +3,7 @@
 #![feature(try_blocks)]
 
 pub fn main() {
-    let res: Result<u32, i32> = try {
+    let res: Result<u32, std::array::TryFromSliceError> = try {
         Err("")?; //~ ERROR `?` couldn't convert the error
         5
     };
index 2d1313d7d0e31a0f88f1de061fa7c6abbd3007d4..75a42c0d6b71b9f08103de11072e2aa50054ceb7 100644 (file)
@@ -1,16 +1,12 @@
-error[E0277]: `?` couldn't convert the error to `i32`
+error[E0277]: `?` couldn't convert the error to `TryFromSliceError`
   --> $DIR/try-block-bad-type.rs:7:16
    |
 LL |         Err("")?;
-   |                ^ the trait `From<&str>` is not implemented for `i32`
+   |                ^ the trait `From<&str>` is not implemented for `TryFromSliceError`
    |
    = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
    = help: the following implementations were found:
-             <i32 as From<NonZeroI32>>
-             <i32 as From<bool>>
-             <i32 as From<i16>>
-             <i32 as From<i8>>
-           and 2 others
+             <TryFromSliceError as From<Infallible>>
    = note: required by `from`
 
 error[E0271]: type mismatch resolving `<Result<i32, i32> as Try>::Ok == &str`