]> git.lizzy.rs Git - rust.git/commitdiff
rustc: Check if def_path_hash_to_def_id is populated before accessing it.
authorFlorian Hahn <florian.hahn@arm.com>
Sun, 18 Jun 2017 15:58:54 +0000 (16:58 +0100)
committerFlorian Hahn <florian.hahn@arm.com>
Sun, 18 Jun 2017 16:01:25 +0000 (17:01 +0100)
Without this patch, there is an ICE when running rustc with
RUST_LOG=debug. This patch updates extract_def_id to check if the map
has been populated before accessing it. This fixes the problem, but
maybe we do not need to compute the incremental hashes maps in the first
place when we are not in incremental mode?

src/librustc/dep_graph/dep_node.rs
src/test/run-pass/rustc-rust-log.rs [new file with mode: 0644]

index b061663148d4ddb87f5d4f4882173e47380a126c..92efeb7fd8629acf6f1e68577d8dbff8219804f0 100644 (file)
@@ -257,11 +257,11 @@ pub fn new_no_params(kind: DepKind) -> DepNode {
             pub fn extract_def_id(&self, tcx: TyCtxt) -> Option<DefId> {
                 if self.kind.can_reconstruct_query_key() {
                     let def_path_hash = DefPathHash(self.hash);
-                    tcx.def_path_hash_to_def_id
-                       .as_ref()
-                       .unwrap()
-                       .get(&def_path_hash)
-                       .cloned()
+                    if let Some(ref def_path_map) = tcx.def_path_hash_to_def_id.as_ref() {
+                        def_path_map.get(&def_path_hash).cloned()
+                    } else {
+                       None
+                    }
                 } else {
                     None
                 }
diff --git a/src/test/run-pass/rustc-rust-log.rs b/src/test/run-pass/rustc-rust-log.rs
new file mode 100644 (file)
index 0000000..629387d
--- /dev/null
@@ -0,0 +1,13 @@
+// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// rustc-env:RUST_LOG=debug
+
+fn main() {}