]> git.lizzy.rs Git - cheatdb.git/commitdiff
Use .get() instead of filter_by() for primary key queries
authorrubenwardy <rw@rubenwardy.com>
Mon, 26 Mar 2018 11:55:41 +0000 (12:55 +0100)
committerrubenwardy <rw@rubenwardy.com>
Mon, 26 Mar 2018 11:55:41 +0000 (12:55 +0100)
app/views/packages.py

index dfe7af040c499183ed14de6aa18a483451899e3a..d1bf20ecce29f6fc9c1810baa9e7a515c0e4b295 100644 (file)
@@ -283,7 +283,7 @@ def create_editrequest_page(ptype, author, name):
 def view_editrequest_page(ptype, author, name, id):
        package = getPageByInfo(ptype, author, name)
 
-       erequest = EditRequest.query.filter_by(id=id).first()
+       erequest = EditRequest.query.get(id)
        if erequest is None:
                abort(404)
 
@@ -297,7 +297,7 @@ def approve_editrequest_page(ptype, author, name, id):
                flash("You don't have permission to do that.", "error")
                return redirect(package.getDetailsURL())
 
-       erequest = EditRequest.query.filter_by(id=id).first()
+       erequest = EditRequest.query.get(id)
        if erequest is None:
                abort(404)
 
@@ -318,7 +318,7 @@ def reject_editrequest_page(ptype, author, name, id):
                flash("You don't have permission to do that.", "error")
                return redirect(package.getDetailsURL())
 
-       erequest = EditRequest.query.filter_by(id=id).first()
+       erequest = EditRequest.query.get(id)
        if erequest is None:
                abort(404)
 
@@ -387,7 +387,7 @@ def edit_release_page(type, author, name, id):
        if user is None:
                abort(404)
 
-       release = PackageRelease.query.filter_by(id=id).first()
+       release = PackageRelease.query.get(id)
        if release is None:
                abort(404)