]> git.lizzy.rs Git - rust.git/commitdiff
Fix miscompile in SimplifyBranchSame
authorSimon Vandel Sillesen <simon.vandel@gmail.com>
Sun, 4 Oct 2020 00:00:00 +0000 (00:00 +0000)
committerTomasz Miąsko <tomasz.miasko@gmail.com>
Sun, 4 Oct 2020 00:00:00 +0000 (00:00 +0000)
compiler/rustc_mir/src/transform/simplify_try.rs

index e6b7345d6e48842412465c747fdc023c622ab5c2..a4e7a5a94533d97f903a55309959fb985aa4a4e7 100644 (file)
@@ -630,7 +630,8 @@ fn find(&self) -> Vec<SimplifyBranchSameOptimization> {
                 // All successor basic blocks must be equal or contain statements that are pairwise considered equal.
                 for ((target_and_value_l,bb_l), (target_and_value_r,bb_r)) in iter_bbs_reachable.tuple_windows() {
                     let trivial_checks = bb_l.is_cleanup == bb_r.is_cleanup
-                    && bb_l.terminator().kind == bb_r.terminator().kind;
+                                            && bb_l.terminator().kind == bb_r.terminator().kind
+                                            && bb_l.statements.len() == bb_r.statements.len();
                     let statement_check = || {
                         bb_l.statements.iter().zip(&bb_r.statements).try_fold(StatementEquality::TrivialEqual, |acc,(l,r)| {
                             let stmt_equality = self.statement_equality(*adt_matched_on, &l, target_and_value_l, &r, target_and_value_r);