std::trie: make lower_bound and upper_bound about 15% faster.

I believe this is mainly due to code-size reduction.

Before:

    test [...]::bench_lower_bound ... bench:       818 ns/iter (+/- 100)
    test [...]::bench_upper_bound ... bench:       939 ns/iter (+/- 34)

After:

    test [...]::bench_lower_bound ... bench:       698 ns/iter (+/- 60)
    test [...]::bench_upper_bound ... bench:       817 ns/iter (+/- 20)

diff --git a/src/libstd/trie.rs b/src/libstd/trie.rs
index 94b7b881ea0d88248329ebd63a69d06a58ab23c5..d864cde2953ea1ad30760455cbce86f14a803d85 100644 (file)
--- a/src/libstd/trie.rs
+++ b/src/libstd/trie.rs
@@ -198,24 +198,24 @@ macro_rules! bound {
             addr!(loop {
                     let children = unsafe {addr!(& $($mut_)* (*node).children)};
                     let child_id = chunk(key, idx);
-                    match children[child_id] {
+                    let (slice_idx, ret) = match children[child_id] {
                         Internal(ref $($mut_)* n) => {
                             node = addr!(& $($mut_)* **n as * $($mut_)* TrieNode<T>);
+                            (child_id + 1, false)
                         }
                         External(stored, _) => {
-                            if stored < key || ($upper && stored == key) {
-                                it.stack.push(children.$slice_from(child_id + 1).$iter());
+                            (if stored < key || ($upper && stored == key) {
+                                child_id + 1
                             } else {
-                                it.stack.push(children.$slice_from(child_id).$iter());
-                            }
-                            return it;
+                                child_id
+                            }, true)
                         }
                         Nothing => {
-                            it.stack.push(children.$slice_from(child_id + 1).$iter());
-                            return it
+                            (child_id + 1, true)
                         }
-                    }
-                    it.stack.push(children.$slice_from(child_id + 1).$iter());
+                    };
+                    it.stack.push(children.$slice_from(slice_idx).$iter());
+                    if ret { return it }
                     idx += 1;
                 })
         }