]> git.lizzy.rs Git - rust.git/commitdiff
Extract semantic constant
authorThiago Arrais <thiago.arrais@gmail.com>
Mon, 8 Jul 2019 16:12:51 +0000 (13:12 -0300)
committerThiago Arrais <thiago.arrais@gmail.com>
Mon, 8 Jul 2019 20:51:13 +0000 (17:51 -0300)
clippy_lints/src/strings.rs

index 9be2d40bae1f235b45de125fc109bffd4f54665c..57f63a600a7c7dbea170cc3da2a423c6022a37bf 100644 (file)
@@ -138,6 +138,9 @@ fn is_add(cx: &LateContext<'_, '_>, src: &Expr, target: &Expr) -> bool {
     }
 }
 
+// Max length a b"foo" string can take
+const MAX_LENGTH_BYTE_STRING_LIT: usize = 32;
+
 declare_lint_pass!(StringLitAsBytes => [STRING_LIT_AS_BYTES]);
 
 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for StringLitAsBytes {
@@ -173,7 +176,7 @@ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
                             );
                         } else if callsite == expanded
                             && lit_content.as_str().chars().all(|c| c.is_ascii())
-                            && lit_content.as_str().len() <= 32
+                            && lit_content.as_str().len() <= MAX_LENGTH_BYTE_STRING_LIT
                             && !in_macro_or_desugar(args[0].span)
                         {
                             span_lint_and_sugg(