]> git.lizzy.rs Git - rust.git/commitdiff
librustc: Update AutoObject adjustment in writeback.
authorLuqman Aden <laden@csclub.uwaterloo.ca>
Thu, 5 Jun 2014 22:06:33 +0000 (18:06 -0400)
committerAlex Crichton <alex@alexcrichton.com>
Sat, 7 Jun 2014 02:51:17 +0000 (19:51 -0700)
src/librustc/middle/typeck/check/regionck.rs
src/librustc/middle/typeck/check/writeback.rs
src/test/run-pass/issue-11612.rs [new file with mode: 0644]

index e1db465424af88946486e9362e1f09bed4082c93..e488a946d4a14deae9248086f154691fd8d7c040 100644 (file)
@@ -432,7 +432,7 @@ fn visit_expr(rcx: &mut Rcx, expr: &ast::Expr) {
                 // function check_cast_for_escaping_regions() in kind.rs
                 // explaining how it goes about doing that.
 
-                let source_ty = rcx.fcx.expr_ty(expr);
+                let source_ty = rcx.resolve_node_type(expr.id);
                 constrain_regions_in_type(rcx, trait_region,
                                             infer::RelateObjectBound(expr.span), source_ty);
             }
index 63dc122f7cbf64c3082ae050e15e631466a7df71..b93550384ae3b1483b51bc91d8f58ced9ed48f5f 100644 (file)
@@ -260,7 +260,14 @@ fn visit_adjustments(&self, reason: ResolveReason, id: ast::NodeId) {
                         })
                     }
 
-                    adjustment => adjustment
+                    ty::AutoObject(trait_store, bb, def_id, substs) => {
+                        ty::AutoObject(
+                            self.resolve(&trait_store, reason),
+                            self.resolve(&bb, reason),
+                            def_id,
+                            self.resolve(&substs, reason)
+                        )
+                    }
                 };
                 debug!("Adjustments for node {}: {:?}", id, resolved_adjustment);
                 self.tcx().adjustments.borrow_mut().insert(
diff --git a/src/test/run-pass/issue-11612.rs b/src/test/run-pass/issue-11612.rs
new file mode 100644 (file)
index 0000000..5fb2274
--- /dev/null
@@ -0,0 +1,30 @@
+// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// #11612
+// We weren't updating the auto adjustments with all the resolved
+// type information after type check.
+
+trait A {}
+
+struct B<'a, T> {
+    f: &'a T
+}
+
+impl<'a, T> A for B<'a, T> {}
+
+fn foo(_: &A) {}
+
+fn bar<G>(b: &B<G>) {
+    foo(b);       // Coercion should work
+    foo(b as &A); // Explicit cast should work as well
+}
+
+fn main() {}