]> git.lizzy.rs Git - rust.git/commitdiff
rustdoc: replace DIV inside H1 with SPAN.
authorNODA, Kai <nodakai@gmail.com>
Wed, 24 Sep 2014 04:47:25 +0000 (12:47 +0800)
committerNODA, Kai <nodakai@gmail.com>
Thu, 25 Sep 2014 08:10:07 +0000 (16:10 +0800)
W3C HTML5 spec states that H1 must enclose "phrasing content" which
doesn't include DIV.  But SPAN is OK.
http://www.w3.org/TR/html5/sections.html#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements

src/librustdoc/html/render.rs

index b2cef48af4ca70eafd1339fd9a6aedb9694be056..3cd3fe3053a375cb5d87317d78bce9e5929d0e21 100644 (file)
@@ -1304,7 +1304,7 @@ fn href(&self) -> Option<String> {
 impl<'a> fmt::Show for Item<'a> {
     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
         // Write the breadcrumb trail header for the top
-        try!(write!(fmt, "\n<h1 class='fqn'><div class='in-band'>"));
+        try!(write!(fmt, "\n<h1 class='fqn'><span class='in-band'>"));
         match self.item.inner {
             clean::ModuleItem(ref m) => if m.is_crate {
                     try!(write!(fmt, "Crate "));
@@ -1337,8 +1337,9 @@ fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
         // Write stability level
         try!(write!(fmt, "<wbr>{}", Stability(&self.item.stability)));
 
+        try!(write!(fmt, "</span>")); // in-band
         // Links to out-of-band information, i.e. src and stability dashboard
-        try!(write!(fmt, "</div><div class='out-of-band'>"));
+        try!(write!(fmt, "<span class='out-of-band'>"));
 
         // Write stability dashboard link
         match self.item.inner {
@@ -1370,7 +1371,7 @@ fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
             }
         }
 
-        try!(write!(fmt, "</div>"));
+        try!(write!(fmt, "</span>")); // out-of-band
 
         try!(write!(fmt, "</h1>\n"));