source_file: Lrc<rustc_span::SourceFile>,
override_span: Option<Span>,
) -> Self {
- if source_file.src.is_none() {
+ // Make sure external source is loaded first, before accessing it.
+ // While this can't show up during normal parsing, `retokenize` may
+ // be called with a source file from an external crate.
+ sess.source_map().ensure_source_file_source_present(source_file.clone());
+
+ // FIXME(eddyb) use `Lrc<str>` or similar to avoid cloning the `String`.
+ let src = if let Some(src) = &source_file.src {
+ src.clone()
+ } else if let Some(src) = source_file.external_src.borrow().get_source() {
+ src.clone()
+ } else {
sess.span_diagnostic
.bug(&format!("cannot lex `source_file` without source: {}", source_file.name));
- }
-
- let src = (*source_file.src.as_ref().unwrap()).clone();
+ };
StringReader {
sess,
#[derive(PartialEq, Eq, Clone, Debug)]
pub enum ExternalSourceKind {
/// The external source has been loaded already.
- Present(String),
+ Present(Lrc<String>),
/// No attempt has been made to load the external source.
AbsentOk,
/// A failed attempt has been made to load the external source.
}
}
- pub fn get_source(&self) -> Option<&str> {
+ pub fn get_source(&self) -> Option<&Lrc<String>> {
match self {
ExternalSource::Foreign { kind: ExternalSourceKind::Present(ref src), .. } => Some(src),
_ => None,
hasher.write(src.as_bytes());
if hasher.finish::<u128>() == self.src_hash {
- *src_kind = ExternalSourceKind::Present(src);
+ *src_kind = ExternalSourceKind::Present(Lrc::new(src));
return true;
}
} else {