Auto merge of #51367 - oli-obk:silence!_I_test_you, r=Mark-Simulacrum

Use quiet tests by default

r? @eddyb

diff --combined src/bootstrap/test.rs
index ce6506b0a10fab12cef52208a9c1d115c1d3705f,25a8116ff2a8739ba1049479df24749ab43f101e..d2fd798723dabbf0c6abf809eb50f56b32c11c18
--- 1/src/bootstrap/test.rs
--- 2/src/bootstrap/test.rs
+++ b/src/bootstrap/test.rs
@@@ -632,7 -632,7 +632,7 @@@ impl Step for Tidy 
          if !builder.config.vendor {
              cmd.arg("--no-vendor");
          }
-         if builder.config.quiet_tests {
+         if !builder.config.verbose_tests {
              cmd.arg("--quiet");
          }
  
@@@ -1086,7 -1086,7 +1086,7 @@@ impl Step for Compiletest 
              cmd.arg("--verbose");
          }
  
-         if builder.config.quiet_tests {
+         if !builder.config.verbose_tests {
              cmd.arg("--quiet");
          }
  
@@@ -1397,10 -1397,10 +1397,10 @@@ fn markdown_test(builder: &Builder, com
      let test_args = builder.config.cmd.test_args().join(" ");
      cmd.arg("--test-args").arg(test_args);
  
-     if builder.config.quiet_tests {
-         try_run_quiet(builder, &mut cmd)
-     } else {
+     if builder.config.verbose_tests {
          try_run(builder, &mut cmd)
+     } else {
+         try_run_quiet(builder, &mut cmd)
      }
  }
  
@@@ -1632,7 -1632,7 +1632,7 @@@ impl Step for Crate 
          cargo.arg("--");
          cargo.args(&builder.config.cmd.test_args());
  
-         if builder.config.quiet_tests {
+         if !builder.config.verbose_tests {
              cargo.arg("--quiet");
          }
  
@@@ -1742,7 -1742,7 +1742,7 @@@ impl Step for CrateRustdoc 
          cargo.arg("--");
          cargo.args(&builder.config.cmd.test_args());
  
-         if builder.config.quiet_tests {
+         if !builder.config.verbose_tests {
              cargo.arg("--quiet");
          }
  
@@@ -1921,9 -1921,6 +1921,9 @@@ impl Step for Bootstrap 
              cmd.arg("--no-fail-fast");
          }
          cmd.arg("--").args(&builder.config.cmd.test_args());
 +        // rustbuild tests are racy on directory creation so just run them one at a time.
 +        // Since there's not many this shouldn't be a problem.
 +        cmd.arg("--test-threads=1");
          try_run(builder, &mut cmd);
      }