]> git.lizzy.rs Git - rust.git/commitdiff
Remove unnecessary FIXME (answered by Oli)
authorDylan MacKenzie <ecstaticmorse@gmail.com>
Sun, 5 Dec 2021 21:11:55 +0000 (13:11 -0800)
committerDylan MacKenzie <ecstaticmorse@gmail.com>
Sun, 5 Dec 2021 21:11:55 +0000 (13:11 -0800)
compiler/rustc_mir_transform/src/lib.rs

index a7e003a55b4007e3fe4f901aa1be8dc9b57fd878..130688e2d53d451891be61df22130aae933c95b5 100644 (file)
@@ -480,8 +480,7 @@ fn o1<T>(x: T) -> WithMinOptLevel<T> {
             // FIXME(#70073): This pass is responsible for both optimization as well as some lints.
             &const_prop::ConstProp,
             //
-            // FIXME: The old pass manager ran this only at mir-opt-level >= 1, but
-            // const-prop runs unconditionally. Should this run unconditionally as well?
+            // Const-prop runs unconditionally, but doesn't mutate the MIR at mir-opt-level=0.
             &o1(simplify_branches::SimplifyConstCondition::new("after-const-prop")),
             &early_otherwise_branch::EarlyOtherwiseBranch,
             &simplify_comparison_integral::SimplifyComparisonIntegral,